New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageMaxRewritesAtOnce ignored (but displays correct configured value in admin interface) #1305

Closed
oschaaf opened this Issue May 10, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@oschaaf
Copy link
Member

oschaaf commented May 10, 2016

It looks like the configured ImageMaxRewritesAtOnce is ignored when limiting concurrent image rewrites (and expensive operations), as the default rewrite options value is used which always keeps the default value (8).
The global options from the server context do contain the configured value, but we probably can't use those as the option is process-scoped.

Reported via https://groups.google.com/forum/#!topic/mod-pagespeed-discuss/D93W3Zaycp0 (and #1289 (comment)
)

morlovich added a commit that referenced this issue May 18, 2016

Always parse process config into RewriteDriverFactory::default_options,
and then sync it back to per-ServerContext options. Should fix the
regression with ImageMaxRewritesAtOnce (#1305),
and give RewriteDriverFactory and all the ServerContexts a consistent view of their value.

morlovich added a commit that referenced this issue May 19, 2016

Always parse process config into RewriteDriverFactory::default_options,
and then sync it back to per-ServerContext options. Should fix the
 regression with ImageMaxRewritesAtOnce
(#1305)
and give RewriteDriverFactory and all the ServerContexts a
consistent view of their value.
@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Jun 27, 2016

Fixed by 4f657b9

crowell added a commit that referenced this issue Jul 13, 2016

Always parse process config into RewriteDriverFactory::default_options,
and then sync it back to per-ServerContext options. Should fix the
 regression with ImageMaxRewritesAtOnce
(#1305)
and give RewriteDriverFactory and all the ServerContexts a
consistent view of their value.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment