Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Multiple instances of the cache cleaner can run simultaneously on large caches #1337
Our cache cleaning algorithm is:
We do this once an hour, and if the previous run hasn't completed we start a new run. This means that if your cache is large enough that we can't walk it in an hour you're going to have a bad time.
What we should do instead is either include our PID in the lockfile or keep pinging it every so often to indicate we're still working, so that we know not to start a new cache-cleaning run in the middle of cleaning the cache.
 This is dependent on the fs being mounted with the
I think we should tell users explicitly not to put the file cache on a
So designing a locking system assuming that seems Ok to me. Having said