New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recognize dc.js as a synonym for ga.js #1338

Closed
jeffkaufman opened this Issue Jul 6, 2016 · 4 comments

Comments

Projects
None yet
2 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Jul 6, 2016

stats.g.doubleclick.net/dc.js is a synonym for google-analytics.com/ga.js, for insert_ga purposes. We should recognize scripts that use it, and be willing to make substitutions on them. Doc: https://support.google.com/analytics/answer/2444872

(Reported on the mailing list: https://groups.google.com/forum/#!topic/ngx-pagespeed-discuss/GM8rYlv82cQ)

@jeffkaufman jeffkaufman self-assigned this Jul 6, 2016

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Jul 6, 2016

Patch is out for review.

@centminmod

This comment has been minimized.

Copy link

centminmod commented Jul 6, 2016

thanks @jeffkaufman didn't know dc.js was a synonym !

much appreciated 👍

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Jul 6, 2016

didn't know dc.js was a synonym !

Well, it's not actually a synonym, but it is from ngx_pagespeed's
perspective? My understanding from reading docs (this morning) is
that Double Click's dc,js is an extension of ga.js that adds a few
more features.

@centminmod

This comment has been minimized.

Copy link

centminmod commented Jul 6, 2016

Ah i see :)

crowell added a commit that referenced this issue Jul 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment