New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow people to turn off cache cleaning #1343

Closed
jeffkaufman opened this Issue Jul 7, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@jeffkaufman
Copy link
Contributor

jeffkaufman commented Jul 7, 2016

Right now you can turn off the "delete things" aspect of cache cleaning, but not the "check the whole cache to see what should be cleaned" aspect.

This should probably look like:

ModPagespeedFileCacheCleanIntervalMs -1

@jeffkaufman jeffkaufman self-assigned this Jul 7, 2016

@morlovich

This comment has been minimized.

Copy link
Contributor

morlovich commented Jul 7, 2016

Note that the interval is an int64, so it should be possible to just put in a sufficiently giant number as a workaround (3000000000000 would likely do --- it's around 95 years).

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

jeffkaufman commented Jul 7, 2016

Yes, a giant number is what I suggested on the thread, but we should support -1 and doc it.

(I should also reread the code and make sure you can turn off all of our "uh oh, something's funny, better clean the cache" checks.)

crowell added a commit that referenced this issue Jul 21, 2016

cache-cleaning: allow people to turn it off
Support 'FileCacheCleanIntervalMs -1' to turn off cache cleaning.

Fixes #1343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment