Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-updating broken with new deb systems #1428

Closed
jeffkaufman opened this issue Nov 10, 2016 · 9 comments
Closed

Auto-updating broken with new deb systems #1428

jeffkaufman opened this issue Nov 10, 2016 · 9 comments

Comments

@jeffkaufman
Copy link
Contributor

@jeffkaufman jeffkaufman commented Nov 10, 2016

Ubuntu 16.10 and the forthcoming Debian 9 have a change that breaks our auto-updating. Chrome ran into the same bug https://bugs.chromium.org/p/chromium/issues/detail?id=663069 and has a patch: https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0

This is more serious for Chrome than mod_pagespeed because Debian 9 is still unstable, and people usually don't use non-LTS Ubuntu for servers, but it's still pretty urgent. We probably need to put out a patch release for this.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 10, 2016

We may be able to fix this by modifying the existing packages without a full rebuild, since it's a packaging issue and not a code issue.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 10, 2016

This is now fixed on master but still needs to get released, and since it's a packaging issue I want to keep the bug open.

I've modified our existing packages in-place to make three changes:

  • Change r0 to r1 in the filename and in control.tar.gz:./control:Version
  • Add required slashes to control.tar.gz:./postinst:find_apt_sources
  • Add required slashes to control.tar.gz:./postrm:find_apt_sources

Next step is to spin up VMs to test these, which I'm planning to do tomorrow morning.

If that goes well I'll plan to sign the packages, and push them out first thing monday morning.

jeffkaufman added a commit that referenced this issue Nov 11, 2016
In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a
trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was
concatenating that variable into a path, assuming the trailing slash. But in
Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file,
and the cronjob fails to fix it.

Patch from https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0

Fixes #1428
jeffkaufman added a commit that referenced this issue Nov 11, 2016
In prior versions of Ubuntu/Debian the Dir::Etc apt-config variable contained a
trailing slash by default. The cronjob at /etc/cron.daily/google-chrome was
concatenating that variable into a path, assuming the trailing slash. But in
Ubuntu 16.10, the trailing slash is gone. That breaks the path to the list file,
and the cronjob fails to fix it.

Patch from https://chromium.googlesource.com/chromium/src.git/+/389af6af989c5ba5384988b55fc28a3f231a1479%5E%21/#F0

Fixes #1428
@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

Modifying the package in place means the version we compiled-in is wrong. I'm going to stop messing with this and just build packages the right way, building a debian-only patch release 1.11.33.5

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

I've built the first round of packages (64-bit debs) and am testing them. I've set up four VMs:

  • ubuntu 16.04 vs 16.10
  • upgrade vs plain

On the upgrade ones I'm going to first install 1.11.33.4 and then 1.11.33.5, while on the plain ones I'll just install 1.11.33.5.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

Installing 1.11.33.4 on 16.04 and 16.10, I see mod-pagespeed.list in /etc/apt/sources.list.d on 16.04 but not on 16.10. When I run sudo apt-get update I see 16.04 checking with http://dl.google.com/linux/mod-pagespeed/deb and 16.10 not.

So: bug reproduced.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

After installing 1.11.33.5 on all four VMs, all four show mod-pagespeed.list in /etc/apt/sources.list.d, and all four check with http://dl.google.com/linux/mod-pagespeed/deb on sudo apt-get update

So: bug confirmed fixed by 1.11.33.5

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

(For future reference, I'm seeing build_release_platform.sh take 35 minutes. I'm running things serially on the ubuntu-12 buildbot, but after @hillsp finishes his changes we'll be able to run them in parallel, each on its own vm.)

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 11, 2016

Packages are built and signed. Planning to push them out monday morning to avoid releasing on a friday afternoon.

@jeffkaufman
Copy link
Contributor Author

@jeffkaufman jeffkaufman commented Nov 14, 2016

1.11.33.5 is released and announced; closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant