New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat the entire input file, including tags and attribute names, as case sensitive #153

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Enable mod_pagespeed on http://www.shopwatchbuy.com
2. Go to page http://www.shopwatchbuy.com/gallery-compositions-pid423
3. Try to play the flash 

What is the expected output? What do you see instead?

Expected:  to call the video url:
Actual:    did not call the video url

What version of the product are you using (please check X-Mod-Pagespeed
header)?

mod-pagespeed-beta-0.9.11.5-293

Additionally, the site owner tried "ModPagespeedDisallow *" which means all 
resource rewriting is completely off.  So this problem must be caused by some 
HTML processing, either the parsing/re-serialization, or some optional filter 
such as remove_comments.



Original issue reported on code.google.com by jmara...@google.com on 15 Dec 2010 at 2:39

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

The issue is quite possibly due to handling of the file 
http://www.shopwatchbuy.com/webservices/getvideodata/type/product/productId/423/
productType/standard (and similar ones). That's an XML file (served 
inaccurately as text/html), and we end up lowercasing some tags in it. 

Original comment by morlov...@google.com on 16 Dec 2010 at 8:57

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

The flash seems to be working fine now.

Original comment by sligocki@google.com on 31 Dec 2010 at 12:44

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This site is not running mod_pagespeed anymore so we cannot verify the fix.  
However, we have a fix for spurious lower-casing of tags in flight so we should 
hopefully not see this problem again.

Original comment by jmara...@google.com on 14 Jan 2011 at 6:30

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Upon further discussion we are re-opening this bug, and changing its summary to 
reflect the root cause.

The old summary was: mod_pagespeed breaks custom flash player on 
http://www.shopwatchbuy.com/gallery-compositions-pid423


HTML tags and attribute values are case insensitive, but (a) there is much XML 
on the Web that lies about its content_type and (b) XML is, evidently, 
case-sensitive.  So to avoid munging it we should always retain the original 
case.

Original comment by jmara...@google.com on 14 Jan 2011 at 6:44

  • Changed title: Treat the entire input file, including tags and attribute values, as case sensitive
  • Changed state: New
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I've turned Mod_pagespeed back on if you'd like to reexamine.  However, we 
rewrote the code and flash player to use all lower-case anyway.  Thanks!

Original comment by kpr...@shopwatchbuy.com on 17 Jan 2011 at 5:32

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks -- we're going to leave this bug open and try to add more intelligence 
about identifying markup as HTML when really it's not.  There's a lot of 
content out there in the wild that identifies itself as content-type:text/html 
when it is not.

Original comment by jmara...@google.com on 20 Jan 2011 at 4:47

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 28 Feb 2011 at 6:08

  • Changed title: Treat the entire input file, including tags and attribute names, as case sensitive
  • Changed state: New
  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 28 Feb 2011 at 6:08

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment