New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a way to turn off query-params #259

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

Query-params allow clients to change the set of filters executed by 
mod_pagespeed, overriding settings in pagespeed.conf &/or .htaccess.

Site owners should have a way to limit or disable this functionality entirely.  
For example, site owners might want to (a) turn off the query-params 
functionality entirely or (b) prevent users from turning on specific filters.

Original issue reported on code.google.com by jmara...@google.com on 7 Apr 2011 at 2:51

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 7 Apr 2011 at 2:54

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Perhaps we could allow richer restrictions, like specifying where query params 
are allowed from (say localhost). Like we do for statistics access.

Original comment by sligocki@google.com on 8 Apr 2011 at 5:23

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Yes, once the development and debugging is over, I would like to turn these 
parameters off.

Original comment by webmas...@clubsilver.org on 11 Apr 2011 at 4:08

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 24 May 2012 at 7:26

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 28 Nov 2012 at 7:12

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Matt can you confirm this is now addressed?

Original comment by jmara...@google.com on 28 Nov 2012 at 7:13

  • Added labels: Milestone-v24, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

ModPagespeedForbidFilters is implemented in trunk, which allows the admin to 
disable and disallow nominated filters.

Disallow means that a browser can't enable them with headers or query params, 
and an attempt to do so will result in the unoptimized resource being returned.

Still to come: documentation, ModPagespeedForbidAllDisabledFilters that 
disallows ALL disabled filters without having to list them explicitly.

Original comment by matterb...@google.com on 28 Nov 2012 at 7:20

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

ForbidAllDisabledFilters is done and documented and will be in release 1.1.24.x

Original comment by matterb...@google.com on 6 Dec 2012 at 9:29

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment