New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serf unittest failure outside USA because of redirect #265

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

SerfUrlAsyncFetcherTests fail outside of the US, because there, 
http://www.google.com/ 302-redirects to http://www.google.<CountryCode>/

This is not actually a problem, but the unittest fails.

[ RUN      ] SerfUrlAsyncFetcherTest.FetchOneURL
[0410/192627:INFO:net/instaweb/util/google_message_handler.cc(29)]
Initiating blocking fetch for http://www.google.com/
[0410/192628:INFO:net/instaweb/util/google_message_handler.cc(29)]
Fetch complete: http://www.google.com/
net/instaweb/apache/serf_url_async_fetcher_test.cc:167: Failure
Value of: response_headers_[idx]->status_code()
 Actual: 302
Expected: 200
net/instaweb/apache/serf_url_async_fetcher_test.cc:169: Failure
Value of: contents_[idx]->substr(0, content_starts_[idx].size())
 Actual: "<HTML><HEAD><me"
Expected: content_starts_[idx]
Which is: "<!doctype html>"
net/instaweb/apache/serf_url_async_fetcher_test.cc:243: Failure
Expected: (7500) < (bytes_count), actual: 7500 vs 218
[0410/192628:INFO:net/instaweb/apache/serf_url_async_fetcher.cc(457)]
Waiting for threaded serf fetcher to terminate
[  FAILED  ] SerfUrlAsyncFetcherTest.FetchOneURL (393 ms)

Original issue reported on code.google.com by sligocki@google.com on 11 Apr 2011 at 3:47

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r811.

Original comment by sligocki@google.com on 7 Jul 2011 at 9:32

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 7 Jul 2011 at 9:34

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment