New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

domain sharding sends all relative URLs ref'd from CSS file to the domain-shard of the CSS file. #295

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 10 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

I will work on a testcase to repro.

Original issue reported on code.google.com by jmara...@google.com on 18 May 2011 at 3:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This problem was found with a css file that was cache-extended and its embedded 
URLs absolutified via CssTagScanner::AbsolutifyUrls.  The real CSS parser was 
not used.


Original comment by jmara...@google.com on 18 May 2011 at 3:44

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

There are a couple of problems that are contributing to this symptom:

 - rewrite_css is not able to handle the styles.css on this site --
   there is probably a syntax error in the file.
 - extend_cache is able to handle it, but was, for various reasons, not attempting
   to rewrite the relative URL references in it.  This was causing all of the
   embedded URLs to inherit the shard of the cache-extended CSS file, resulting
   in the imbalance.  That have been fixed.
 - we were not domain-sharding the relative URL references inside
   cache-extended files. This has been fixed.

I'm en route to committing these fixes; they require a bit more cleanup.

Original comment by jmara...@google.com on 18 May 2011 at 6:47

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in r718.

Specifically:

extend_cache is now rewriting the relative URL references inside CSS files 
properly
Domain-sharding has been added to the cache extender.

I have not yet investigated why rewrite_css is not able to handle this 
particular file, but that's really a different issue which is being looked at 
in other contexts.  See Issue 299

Original comment by jmara...@google.com on 21 May 2011 at 1:20

  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 21 May 2011 at 1:32

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks Josh! You rocks! .. I have just downloaded the latest trunk and it works 
like a champ.

Original comment by jimyjo...@gmail.com on 21 May 2011 at 1:59

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Re-opening; this is fixed for CSS that's cache-extended.  But we need to apply 
similar fixes for css inlining and combining.

Original comment by jmara...@google.com on 25 May 2011 at 7:16

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 31 May 2011 at 9:48

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmaes...@google.com on 15 Jul 2011 at 1:59

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This is not yet fixed for combine_css or inline_css, so we need to leave it 
open.

Original comment by jmara...@google.com on 15 Jul 2011 at 2:21

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in r1037.

Original comment by sligocki@google.com on 30 Sep 2011 at 6:30

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment