New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurrence of 285 under X-Mod-Pagespeed:0.9.17.7-716 #300

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?

As per #285, "cache" directory get re-created with "root" permissions.

Original issue reported on code.google.com by webmas...@clubsilver.org on 21 May 2011 at 8:10

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 21 May 2011 at 9:43

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Ouch. I know what I did wrong to introduce this regression. Will fix, but first 
I will do some work to make it testable. 

Original comment by morlov...@google.com on 23 May 2011 at 1:37

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Could you perhaps tell me what distribution and version you are you using? I 
think I really understand the problem & have a tentative fix now (my initial 
guess was wrong), but the cause is highly distro-dependent, so it'd probably be 
a good idea to test with the same OS/apache version.

Original comment by morlov...@google.com on 27 May 2011 at 8:15

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Apache 2.2.17 on Fedora 11 running X-Mod-Pagespeed:0.9.17.7-716

Original comment by webmas...@clubsilver.org on 27 May 2011 at 10:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks. I still can't reproduce the problem with it (but of course my 
configuration may be different), but testing with Fedora 11 was certainly 
valuable as it helped me catch a potential regression, so now I am reasonably 
comfortable that the code as of r r747 will handle most cases.

Original comment by morlov...@google.com on 2 Jun 2011 at 9:40

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I just compiled r748 and it creates directories with correct permissions.

Original comment by webmas...@clubsilver.org on 3 Jun 2011 at 2:44

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 3 Jun 2011 at 3:05

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment