New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trim_urls in CSS that were Absolutified (in say extend_cache or combine_css) #303

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

CacheExtender and CssCombineFilter absolutify URLs with the old CSS URL. They 
should then trim the URLs with the new CSS URL.

Original issue reported on code.google.com by sligocki@google.com on 26 May 2011 at 12:54

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Actually CacheExtender does not absolutify URLs; it domain-rewrites them, but 
it should also trim them.

Probably this should be solved in conjunction with Issue 295, maybe sharing 
some code.

Original comment by jmara...@google.com on 26 May 2011 at 2:03

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 31 May 2011 at 9:47

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Has this been addressed?  Please update or close.

Original comment by jmaes...@google.com on 15 Jul 2011 at 1:58

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

It's fixed for CacheExtender but not CssCombineFilter.  I'm working on that now 
in fact.

Original comment by jmara...@google.com on 15 Jul 2011 at 2:17

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Actually I'm not working on this one...I'm working on Issue 295 but maybe this 
will get done as a side effect.


Original comment by jmara...@google.com on 15 Jul 2011 at 2:22

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in r1037.

Original comment by sligocki@google.com on 18 Oct 2011 at 2:10

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 18 Oct 2011 at 2:10

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment