New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine_css emits "<link ...>" without the proper "/" before the ">" with doctype XHTML #306

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

Hi All

I've just installed mod-pagespeed on our Cent-OS/Apache server. Seems
to work, but it is breaking w3c xhtml validation because when
combining multiple css sheets, mod-pagespeed is rewriting the link in
the wrong format. Specifically, it ending the string with '>' rather
than '/>'.

My page headers are:

<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://
www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">

But the combined css stylesheets are being rewritten as:

<link rel="stylesheet" type="text/css" href="css/stylesheet1.css
+stylesheet2.css,Mcc.ZvSQoMpNxD.css.pagespeed.cf.-MagyA9zJa.css">


Is this a known bug and/or have I got things configured incorrectly.
Any help would be much appreciated.

Original issue reported on code.google.com by jmara...@google.com on 10 Jun 2011 at 7:20

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 14 Jul 2011 at 3:23

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

reproduced & fixed in code; will mark bug fixed when it's checked into svn.

Original comment by jmara...@google.com on 14 Jul 2011 at 3:41

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in r821

Original comment by jmara...@google.com on 14 Jul 2011 at 6:15

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 14 Jul 2011 at 6:15

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment