New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-caching-related headers are stripped from resources #324

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

When mod_pagespeed rewrites a resource, it generates a complete fresh set of 
response-headers so the caching is correct.  But it should retain any 
non-caching-related response-headers in the response.

E.g. if a site has this in a conf file:

           Header append 'DEV' '1'

The origin resource will include "DEV:1" but not the rewritten resource.

Original issue reported on code.google.com by jmara...@google.com on 20 Jul 2011 at 3:20

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 21 Jul 2011 at 4:41

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in r841

Original comment by jmara...@google.com on 21 Jul 2011 at 5:43

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 30 Oct 2011 at 2:17

  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 30 Oct 2011 at 2:21

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Is this fix already included in the latest binary release? I don't think so as 
enabling mod_pagespeed on my server eats ANY header I set using mod_headers. Do 
I need to install from source to get this fix?

Original comment by tobias.w...@gmail.com on 31 Jan 2012 at 5:18

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Yes you need to build 'trunk' from source to get this fix.  We are working on 
polishing up a new release that has this change.

Original comment by jmara...@google.com on 31 Jan 2012 at 5:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

[deleted comment]
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Sorry I confused this with a different issue: 
http://code.google.com/p/modpagespeed/issues/detail?id=367.   This one, 324, is 
fixed in the latest binary release 0.10.19.5.

Original comment by jmara...@google.com on 31 Jan 2012 at 7:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment