Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoadFromFile should convert %20 to space in URLs #332

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

LoadFromFile should convert %20 to space in URLs #332

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

From Hans van Eijsden:

When I enable ModPagespeedLoadFromFile, I get a lot of errors in my Apache 
error log.

My config rule: ModPagespeedLoadFromFile "http://www.weblogzwolle.nl/images/" 
"/home/weblogzwolle/www/images/"

I discovered, that the problematic URL's are the URL's with spaces in them or 
%20's. Although they exist for Apache and the browsers, they don't, of course, 
seem to exist for the file system.
Is there a way, to let mod_pagespeed rewrite %20's back to spaces, when reading 
directly from the file system via ModPagespeedLoadFromFile?
Unfortunately, I had to disable ModPagespeedLoadFromFile completely for now.

Thanks!

Here is a part of my Apache error log:

[Sat Aug 06 02:07:29 2011] [error] [mod_pagespeed 0.9.18.6-886 @12924] 
/home/weblogzwolle/www/images/stories/Brandweer/Tak%204.jpg:0: open input file 
(code=2 No such file or directory)
[Sat Aug 06 02:07:29 2011] [error] [mod_pagespeed 0.9.18.6-886 @12924] 
/home/weblogzwolle/www/images/stories/Brandweer/Tak%202.jpg:0: open input file 
(code=2 No such file or directory)

Original issue reported on code.google.com by sligocki@google.com on 8 Aug 2011 at 6:21

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

It seems like we ought to decode URLs in general before looking them up in the 
file-system. Is there any reason not to do this in general?

Original comment by sligocki@google.com on 8 Aug 2011 at 6:22

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

We'd need to be careful about non-filename-legal characters and unicode, but 
it's a good idea.

Original comment by jmaes...@google.com on 8 Aug 2011 at 1:04

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r1264.

Original comment by sligocki@google.com on 14 Dec 2011 at 7:22

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by matterb...@google.com on 26 Jan 2012 at 3:06

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.