New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine_css needs to strip BOM markers before combining #338

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

See:

http://www.w3.org/TR/css3-syntax/
http://www.w3.org/International/tutorials/tutorial-char-enc/#bom


Original issue reported on code.google.com by jmara...@google.com on 30 Aug 2011 at 9:48

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by nfor...@google.com on 18 Oct 2011 at 2:14

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I was not able to verify this fix, i have two CSS files with a BOM and when 
combine_css runs, it combines them and keeps the BOM.  Is there a changeset or 
revision number I can take a look at?

Original comment by iwokadzi...@gmail.com on 19 Dec 2011 at 7:17

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This bug was not properly fixed at time time we marked it as such last month, 
but we believe it's fixed in trunk now, as of this revision:  
http://code.google.com/p/modpagespeed/source/detail?r=1276

Original comment by jmara...@google.com on 19 Dec 2011 at 7:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Yeah, this got broken in a later revision.
You need parts of r1272 and of r1276 to re-fix it.

Original comment by morlov...@google.com on 19 Dec 2011 at 7:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by matterb...@google.com on 26 Jan 2012 at 3:16

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment