Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightbox2 + mod_pagespeed not working #352

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 7 comments
Closed

Lightbox2 + mod_pagespeed not working #352

GoogleCodeExporter opened this issue Apr 6, 2015 · 7 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Setup lightbox2 script (http://lokeshdhakar.com/projects/lightbox2/)
2. Enable pagespeed
3. See the problem

What is the expected output? What do you see instead?
Lightbox stops working with 

What version of the product are you using (please check X-Mod-Pagespeed
header)?
mod_pagespeed release 0.9.18.6
On what operating system?
Linux
Which version of Apache?
2.2.16




Original issue reported on code.google.com by analyti...@weblux.md on 29 Nov 2011 at 3:47

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

OK, can confirm with current work versions. Looking into it.

Original comment by morlov...@google.com on 29 Nov 2011 at 3:57

  • Changed state: Accepted
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

if needed I can provide demo pages.

Original comment by analyti...@weblux.md on 29 Nov 2011 at 4:00

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

The example on the lightbox page is luckily sufficient. Likely cause: 
scriptaculous.js?load=effects,builder is a loader script which finds itself by 
.src, yet we inline it.

Suggested workaround:
ModPagespeedDisallow *scriptaculous.js*

@sligocki: more for the blacklist?


Original comment by morlov...@google.com on 29 Nov 2011 at 4:11

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Would be great if in future releases it's going to work as it should without 
Disallow rules.

Thanks

Original comment by analyti...@weblux.md on 29 Nov 2011 at 4:13

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Please let us know if this Disallow statement works for you. If so, we will 
make it default in future releases.

Original comment by sligocki@google.com on 29 Nov 2011 at 4:16

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Cofirming that Disallow statement works fine.

Original comment by analyti...@weblux.md on 29 Nov 2011 at 4:21

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fixed by source change 1195 (by disallowing scriptalicious.js).

Note that working with scriptalicious.js isn't possible as it is because it 
queries its own URI and we change that when we rewrite the script. If it is 
changed to be more tolerant of our change then we could re-allow it.

Original comment by matterb...@google.com on 26 Jan 2012 at 4:06

  • Changed state: Fixed
  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.