New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModPagespeedLoadFromFile should strip query string params #357

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

I have ModPagespeedLoadFromFile set to look in my directory for the appropriate 
files instead of requesting them from Apache. However, it seems that the query 
string isn't being stripped before modpagespeed tries to find the file.


[...] [error] [mod_pagespeed 0.10.19.4-1209 @20786] 
/home/[...]/public_html/wp-content/plugins/wp-cycle/jquery.cycle.all.min.js?ver=
3.2.1:0: open input file (code=2 No such file or directory)


Just to be clear, that file does exist.

Original issue reported on code.google.com by amat...@gmail.com on 6 Dec 2011 at 11:53

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Yes, we do not strip query strings. Perhaps we should.

But this seems a bit odd, why are you using a query string for a static file? I 
would assume query strings are only used for dynamically generated files (is 
this being used for cache busting?)

Original comment by sligocki@google.com on 7 Dec 2011 at 4:27

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Yeah, the version query string is inserted automatically (and unconditionally) 
by the WordPress CMS. It's used for cache busting so that new versions of the 
assets are served up as they release new versions of the platform. Take a look 
at the script / style URLs in the source of http://ebayinkblog.com to see many 
more examples of such URLs.

Without the ability to strip query strings, ModPagespeedLoadFromFile is sadly 
useless on WordPress.

Original comment by amat...@gmail.com on 7 Dec 2011 at 5:57

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Makes sense and I can't think of any reason not to strip query strings. Looking 
into this.

Original comment by sligocki@google.com on 7 Dec 2011 at 6:05

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r1231.

Original comment by sligocki@google.com on 7 Dec 2011 at 9:57

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 7 Dec 2011 at 9:59

  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment