New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta refresh tags within NOSCRIPT tags get converted to HTTP headers even when javascript is enabled #372

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Enabled convert_meta_tags filter (enabled by default)
2. Include this HTML in page X:
<noscript>
        <meta http-equiv="refresh" content="0;url=/PleaseEnableJavascript">
</noscript>
3. Fetch the page with mod_pagespeed enabled.

What is the expected output? What do you see instead?

If javascript is enabled in my browser, I expect to see my page X.  Instead
I get redirected to PleaseEnableJavscript.

mod_pagespeed is converting the meta refresh to an HTTP header in all cases (is 
ignoring the fact that the meta refresh occurs within a NOSCRIPT tag).


What version of the product are you using (please check X-Mod-Pagespeed
header)?

0.10.19.5-1253


On what operating system?

Linux.

Which version of Apache?

2.2.14


Which MPM?

Prefork.


Original issue reported on code.google.com by ja...@peaceworks.ca on 23 Jan 2012 at 6:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks for the report.

A work-around until we fix this is:

ModPagespeedDisableFilters convert_meta_tags

Original comment by sligocki@google.com on 23 Jan 2012 at 6:42

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by nfor...@google.com on 23 Jan 2012 at 6:42

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This should be fixed in change 1353 (and part in 1352).

Please give it a shot when you have a chance and let me know if it works for 
you.  Thanks!

Original comment by nfor...@google.com on 24 Jan 2012 at 4:47

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by matterb...@google.com on 26 Jan 2012 at 3:07

  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

FYI: I have limited resources so won't be able to test the change until it is 
included in a new release.

Original comment by ja...@peaceworks.ca on 26 Jan 2012 at 3:10

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks Jason ... ANY help in testing it is much appreciated!

Original comment by matterb...@google.com on 26 Jan 2012 at 3:27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment