New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyily Load Images on Webkit Browsers and the Image Input Element #392

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Enable lazyload_images filter
2. Load a webpage within the mod_pagespeed enabled site with an image input 
element <input type="image"... - Particularly when using png files, haven't 
checked JPEGs - could be a rewrite_images issues
3. Scroll up and down the page, weeping as you notice the png files are not 
loaded, regardless of what you do to your htaccess file. Disable layload_images 
and cry in your pillow at night after seeing the incredible pagespeeds you 
could have but cannot

What is the expected output? What do you see instead?
I expect to see the png file loaded

What version of the product are you using (please check X-Mod-Pagespeed
header)?
pagespeed 0.10.21.2-1427

On what operating system?
Linux Fedora 15

Which version of Apache?
Apache/2.2.21

Which MPM?
Prefork

Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.
I would, but I'm not turning this filter on due to the nature of my 
configuration. Drupal CMS with a multisite install.

Original issue reported on code.google.com by a...@sageage1.com on 24 Feb 2012 at 8:21

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

A quick search shows that it appears that some filters don't understand that
an "<input type='image' ...>" element is actually an image, including the
lazy load images filter. Thanks for the heads up.

Original comment by matterb...@google.com on 24 Feb 2012 at 8:31

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

That's what I figured. The odd thing is it's ONLY in WebKit browsers. At first 
I thought it might have just been a Chrome cache thing, but after checking it 
in Safari, I noticed there.

I just checked IE 9 and it's ALSO in there. So UPDATE not JUST WebKit. Though 
it does seem Gecko has immunity.

Let me know when the next release comes out that has a fix, or if there ends up 
being a way to have Lazy Load ignore input:image fields.

Thanks

Original comment by a...@sageage1.com on 24 Feb 2012 at 8:35

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 10 May 2012 at 8:12

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 17 May 2012 at 7:42

  • Added labels: Milestone-v23
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 24 May 2012 at 7:55

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This bug is fixed in HEAD.

Original comment by jmaes...@google.com on 29 Oct 2012 at 6:19

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmaes...@google.com on 29 Oct 2012 at 6:19

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment