New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_pagespeed does not handle application/xhtml+xml #4

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

I serve pages with the mime-type application/xhtml+xml (for xhtml 1.1). This 
should be optimized the same as html, but it does not work. xhtml can also be 
served as text/xml and application/xml but these might need to be handled 
differencly.

Original issue reported on code.google.com by c...@chaz6.com on 3 Nov 2010 at 10:10

Attachments:

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Great, thanks chaz, we know of a few issues we will have parsing and rewriting 
strict XML, but we would like to get this supported fully.

Original comment by sligocki@google.com on 3 Nov 2010 at 11:22

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

shawn you can find the categorization logic that page speed uses here: 
http://code.google.com/p/page-speed/source/browse/lib/trunk/src/pagespeed/core/r
esource.cc#281

we should factor a lot of this code out into common libraries that can be 
shared.

Original comment by bmcqu...@google.com on 4 Nov 2010 at 2:25

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 5 Nov 2010 at 3:01

  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Issue 57 has been merged into this issue.

Original comment by jmara...@google.com on 9 Nov 2010 at 10:33

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Comment from rwap.services:

Line 17, Column 199: end tag for "link" omitted, but OMITTAG NO was specified 
…608ee6f61356.css,_style,s+css,_color,s+js,_countdown,_jquery,ocountdown,s.css
">✉ 
You may have neglected to close an element, or perhaps you meant to 
"self-close" an element, that is, ending it with "/>" instead of ">". 

This relates to where mod_pagespeed has merged several css files together - 
forming the line:

17.<link rel="stylesheet" type="text/css" media="all" 
href="http://173.236.56.78/themes/enuukGreen/cc.f770833204dec8234e53608ee6f61356
.css,_style,s+css,_color,s+js,_countdown,_jquery,ocountdown,s.css


To fit in with XHTML, this should have a proper closing tag -ie:
17.<link rel="stylesheet" type="text/css" media="all" 
href="http://173.236.56.78/themes/enuukGreen/cc.f770833204dec8234e53608ee6f61356
.css,_style,s+css,_color,s+js,_countdown,_jquery,ocountdown,s.css"/


Other issues appear where the module inserts the image dimensions - for example:
<img 
src="http://173.236.56.78/uploaded/img/ce.8645aabfe710d131203e130f259e5c49.site-
logo,g.gif alt="Logo" width=360 height=123 />

This should have quotes around the width and height values, ie:

<img 
src="http://173.236.56.78/uploaded/img/ce.8645aabfe710d131203e130f259e5c49.site-
logo,g.gif alt="Logo" width="360" height="123" />

Rich
www.rwapservices.co.uk

Original comment by jmara...@google.com on 9 Nov 2010 at 10:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by mdste...@google.com on 24 Nov 2010 at 4:08

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 3 Dec 2010 at 10:36

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment