Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_instrumentation filter breaks JS execution on XHTML files #409

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 10 comments
Closed

add_instrumentation filter breaks JS execution on XHTML files #409

GoogleCodeExporter opened this issue Apr 6, 2015 · 10 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Not sure about the whole instrumentation thinggy.
Added it, checked out the messages, checked out the stats, nice but not needed.

- will this be improved in future versions? in its current state this is quite 
pointless except for quick debugging...

Also, adding instrumentation breaks my munin generated stats, check it out live 
here: 
http://zice.ro/munin/serverkompetenz.net/h1870666.serverkompetenz.net/index.html

Error at the top of the page says: 

"This page contains the following errors:
error on line 409 at column 130: EntityRef: expecting ';'
Below is a rendering of the page up to the first error."

Disabling instrumentation removes the error.

Original issue reported on code.google.com by ovi...@pacura.ru on 2 Apr 2012 at 12:16

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

It looks like the '&' in the '&url=' literal is causing this.
Replacing it with '&' makes the error go away but I need to check if the link 
is still good after doing that.

Thanks for the report!

Original comment by matterb...@google.com on 2 Apr 2012 at 12:42

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Summary was: Adding Instrumentation questions

Original comment by sligocki@google.com on 2 Apr 2012 at 6:29

  • Changed title: add_instrumentation filter breaks JS execution
  • Changed state: Accepted
  • Added labels: Type-Defect
  • Removed labels: Type-Enhancement
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 10 May 2012 at 8:16

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

I've got a change outstanding to resolve this.

Note http://code.google.com/p/modpagespeed/source/detail?r=1576 is a partial 
solution but does not resolve the issue, since mod_pagespeed may not have the 
accurate content-type when add_instrumentation runs.

I have a follow-up pending using the famous CDATA hack.

Original comment by jmara...@google.com on 17 May 2012 at 12:38

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 17 May 2012 at 7:48

  • Added labels: Milestone-v22, release-note
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

http://code.google.com/p/modpagespeed/source/detail?r=1578

Original comment by jmara...@google.com on 17 May 2012 at 8:16

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 25 May 2012 at 2:55

  • Changed title: add_instrumentation filter breaks JS execution on XHTML files
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Most probably you are using a cache plugin like Cloudflare, check config.

Original comment by astrofut...@gmail.com on 16 May 2014 at 6:47

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Hi there,

its 2 years later, I switched servers meanwhile, every piece of software 
involved in this bug report has jumped up a few versions so I'd say just close 
this...

Original comment by ovi...@pacura.ru on 16 May 2014 at 6:51

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 16 May 2014 at 6:53

  • Changed state: Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.