New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outline_css does not inherit CDN rewrite rules from ModPagespeedMapRewriteDomain #416

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Put a large amount of inline CSS in a test page at 
http://example.org/index.html
2. Specify a CDN domain of http://eg.org
3. Enable outline_css and combine_css

What is the expected output? What do you see instead?

Expected: inline CSS in now at http://eg.org/somefile.css

Actual: head now contains http://example.org/somefile.css This can only be 
rectified by providing another file in the head to rewrite (and then both are 
combined).

What version of the product are you using (please check X-Mod-Pagespeed
header)?
0.10.21.2-1381

On what operating system?

Ubuntu 10.04

Which version of Apache?

2.2

Apache/2.2.20

Which MPM?
Using Zend Server Community Edition

Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.


Original issue reported on code.google.com by shri...@gmail.com on 17 Apr 2012 at 11:42

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Investigating

Original comment by sligocki@google.com on 17 Apr 2012 at 1:48

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Sorry for the delay.

Note: You should be careful when using outline filters and multiple servers. 
Specifically, you cannot use outline filters when you have multiple backend 
servers (because only the one which did the outlining will be able to serve 
that file). It is possible to safely use outlining with one backend server and 
several front-end CDN servers which will pull the content from your single 
backend server. Is that your setup?

Original comment by sligocki@google.com on 14 May 2012 at 5:50

  • Changed state: Accepted
  • Added labels: Priority-Low
  • Removed labels: Priority-Medium
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Shawn, have you tried to repro with a single backend server? That ought to work.

Original comment by matterb...@google.com on 31 Oct 2012 at 3:14

  • Changed state: RequestClarification
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Hi,

The issue brought up in comment #2 is slightly off track, but I shall answer it 
with my workaround"

to get around the issue of multiple backend, each server has a separate name, 
so server 1 serves from http://example.org and http://cdn1.eg.org, server 2 
servers http://example.org and http://cdn2.eg.org, etc. Thus rendered HTML 
always refers to the CDN of the backend that rendered it. The file is therefore 
always present.

However, the above is not the issue reported. On the same server, with two 
domains (example.org and eg.org), I should see the file link rewritten to serve 
from the second domain. This works for CSS files served on the page (e.g. 
http://example.org/css/somejsfile.css will appear in the rendered HTML as 
http://eg.org/css/somefile.css). However, this does not occur if the CSS is 
outlined: the resultant CSS is present on the original serving domain, not the 
secondary domain.

Original comment by shri...@gmail.com on 31 Oct 2012 at 3:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I'm looking into this problem.

Original comment by sligocki@google.com on 31 Oct 2012 at 5:30

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r2128.

Original comment by sligocki@google.com on 1 Nov 2012 at 9:38

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 1 Nov 2012 at 9:40

  • Added labels: Milestone-v23, release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment