New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compress stylesheet url fails to decode when optimized by pagespeed #427

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. let pagespeed rewrite a stylesheet linked in from 
/combres.axd/SiteMainCss/-854461982/
2. in my case,this gets rewritten to <path>/I..pagespeed.cf.<hash>.css
3. fetchresource fails when called with this rewritten url (i guess it can't 
decode it)

version:
trunk/r1533

regards,

Otto van der Schaaf

Original issue reported on code.google.com by osch...@gmail.com on 1 May 2012 at 12:09

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Do you have a URL for a site where you've reproduced this issue?  Even if 
you've turned off mod_pagespeed, or perhaps in this case just turned off 
rewrite_css, that would help us reproduce and understand the issue.


What exactly do you mean by 'fetchresource' -- do you mean a 404 in the browser 
(e.g. firebug or chrome dev tools) -- or is that a function that's being called 
in some langauge -- or a message in the apache error log?

Original comment by jmara...@google.com on 1 May 2012 at 12:12

  • Changed state: RequestClarification
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

http://simyo.demo.powerhttp.com/ (however, i disabled the problematic 
stylesheet. note that the combress javascript, with a similar url, works fine. 
without any evidence, i have a feeling that the rewritten url gets a double '.' 
where it shouldn't)

by fetchresource, i meant RewriteDriver::FetchResource 

Hope this helps,

Regards, 

Otto van der Schaaf

Original comment by osch...@gmail.com on 1 May 2012 at 12:33

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I can confirm this bug and am working on a fix.

Thanks for the report.

Original comment by sligocki@google.com on 1 May 2012 at 3:21

  • Changed state: Started
  • Added labels: Priority-High
  • Removed labels: Priority-Medium
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r1540.

Original comment by sligocki@google.com on 2 May 2012 at 3:40

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 2 May 2012 at 3:41

  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Hi oschaaf, can you verify this is fixed for you?

Original comment by sligocki@google.com on 2 May 2012 at 3:41

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

confirmed

Original comment by osch...@gmail.com on 2 May 2012 at 4:44

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 22 May 2012 at 7:55

  • Changed title: compress stylesheet url fails to decode when optimized by pagespeed
  • Added labels: Milestone-v22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment