Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModPagespeedDomainRewriteHyperlinks should not work with Domain Sharding #428

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 6 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. ModPagespeedMapRewriteDomain domain_to_write domain_in_html
2. ModPagespeedShardDomain target_domain shard1_domain,shard2_domain
3. ModPagespeedDomainRewriteHyperlinks on

What is the expected output? What do you see instead?
I expect to see sub-resources to be sharded and href links just to be rewritten 
and not sharded.
Instead, I see sub resources sharded and href's sharded also.

What version of the product are you using (please check X-Mod-Pagespeed
header)?
Bleeding Edge as of two weeks ago

On what operating system?
Ubuntu 10.04

Which version of Apache?
Apache 2.2.22

Which MPM?
Worker

Please provide any additional information below, especially a URL or an
HTML file that exhibits the problem.


Original issue reported on code.google.com by hayes...@gmail.com on 3 May 2012 at 1:58

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Confirmed & reproduced.

Original comment by jmara...@google.com on 5 May 2012 at 12:16

  • Changed title: ModPagespeedDomainRewriteHyperlinks should not work with Domain Sharding
  • Changed state: Started
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fix pending review.

Original comment by jmara...@google.com on 5 May 2012 at 12:53

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Just wanted to see when you expect to have this reviewed and committed? I'm 
waiting on this before we push the cache flush support out.

Thanks
Hayes

Original comment by hayes...@gmail.com on 8 May 2012 at 6:45

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

BTW, appreciate the quick turn around on this.

Original comment by hayes...@gmail.com on 8 May 2012 at 6:49

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fixed in http://code.google.com/p/modpagespeed/source/detail?r=1555


This wasn't really a bug in the 0.10.21.2 because the feature didn't exist, but 
we should remember to release-note the new feature.

Original comment by jmara...@google.com on 8 May 2012 at 2:23

  • Changed state: Fixed
  • Added labels: release-note
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 22 May 2012 at 7:51

  • Added labels: Milestone-v22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.