New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some png images not loading #43

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 11 comments

Comments

Projects
None yet
3 participants
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

I am running mod_pagespeed on my test server at: http://173.236.56.78/

However, although it seems to be working properly (in the main), I have a 
slight issue with 3 png images which should appear above the menu bar at the 
top of the pages.

http://173.236.56.78/themes/enuukGreen/box1.png
http://173.236.56.78/themes/enuukGreen/box2.png
and
http://173.236.56.78/themes/enuukGreen/box3.png

The error log files show the following:
[Mon Nov 08 02:14:07 2010] [notice] 
[1108/021407:INFO:net/instaweb/apache/serf_url_async_fetcher.cc(684)] Fetch 
complete: http://173.236.56.78/themes/enuukGreen/box2.png
[Mon Nov 08 02:14:07 2010] [notice] 
[1108/021407:INFO:net/instaweb/util/google_message_handler.cc(29)] Fetch 
succeeded for 
http://173.236.56.78/themes/enuukGreen/img/ce.e83da904e479c9bcb226fa5df597d438.b
ox2,p.png, status=301
[Mon Nov 08 02:14:07 2010] [notice] 
[1108/021407:INFO:net/instaweb/apache/mod_instaweb.cc(247)] ModPagespeed 
OutputFilter called for request 
/themes/enuukGreen/img/ce.e83da904e479c9bcb226fa5df597d438.box2,p.png
[Mon Nov 08 02:14:07 2010] [warn] 
[1108/021407:WARNING:net/instaweb/util/google_message_handler.cc(32)] Fetching 
resource 
http://173.236.56.78/themes/enuukGreen/img/ce.2dcfd6f05b39680620e3a9be36004c50.b
ox3,p.png...
[Mon Nov 08 02:14:07 2010] [notice] 
[1108/021407:INFO:net/instaweb/util/google_message_handler.cc(29)] Fetch 
succeeded for 
http://173.236.56.78/themes/enuukGreen/img/ce.2dcfd6f05b39680620e3a9be36004c50.b
ox3,p.png, status=200


This is running on the latest mod_pagespeed, under Centos 5.5 - apache 2.2.3, 
with Zend Engine v2.2 and eAccelerator installed.

I did originally have php_speedy also installed and in use, but found that 
mod_pagespeed was struggling to access php_speedy's own cached files.

Original issue reported on code.google.com by rwap.services on 7 Nov 2010 at 11:22

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

It is not only png files - my logo jpg was also affected - could it be because 
I have set the expires header on png and jpgs to 1 year in the future?

I also wonder if issue 53 is a duplicate of this?

Original comment by rwap.services on 10 Nov 2010 at 7:34

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

mod_pagespeed version 0.9.8.1-215 is released, and I wanted to see if I could 
try your site using the new version of code.

I cannot reach http://173.236.56.78/ so I'm guessing that was a temporary 
server or a dynamic IP?

Can you give the new version of mod_pagespeed a try and let us know if this is 
still a problem?

Original comment by jmara...@google.com on 17 Nov 2010 at 5:27

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This fixed the issue to some extent (great) - although I think that I have also 
spotted something else which causes this issue.

My <header>..</head> contains

<base href="http://www.sellmyretro.com/" />

The site logo was then being loaded with:
<img src="uploaded/img/site-logo.gif" />

I wonder if mod_pagespeed was not taking account of the base href to find the 
site logo?
I replaced this with a simple:
<img src="/uploaded/img/site-logo.gif" />

and it worked.  However, mod_pagespeed should take accout of the base href 
directive.

Original comment by sexy.ric...@googlemail.com on 17 Nov 2010 at 8:10

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I'm breaking this off as a new issue 94 and marking this one as fixed. We do 
intend to respect base URLs, but that support was added pretty recently and 
might be a little spotty, I'll take a look.

Original comment by sligocki@google.com on 17 Nov 2010 at 3:22

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I added a test for base URLs from ImageRewriteFilter and it passes. Please 
upload a failing example to issue 94.

Original comment by sligocki@google.com on 18 Nov 2010 at 12:36

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Check cache_extend.

Original comment by jmara...@google.com on 18 Nov 2010 at 1:03

@herlon214

This comment has been minimized.

herlon214 commented Jun 3, 2015

The same are happening to me :/
PNG images doesn't show

@jmarantz

This comment has been minimized.

Contributor

jmarantz commented Jun 3, 2015

Hi Herlon214,

I would recommend putting in a new issue with detail on your specific case (URL etc). If you just add your case to a bug that was closed 4.5 years ago it is likely to be missed :)

@herlon214

This comment has been minimized.

herlon214 commented Jun 3, 2015

Thanks for the response @jmarantz, when I disabled the "cache_extend" the images are showing, but they aren't compressed.
Take a look at http://www.ofertasdeemail.com.br/

The image "http://cf-static.ofertasdeemail.com.br/banners/oferta-do-dia-americanas-03-06-2015-3.jpg" isn't being compressed.

@jmarantz

This comment has been minimized.

Contributor

jmarantz commented Jun 3, 2015

Please create a new bug for this issue. The bug you are responding to is
closed.

On Wed, Jun 3, 2015 at 4:52 PM, Herlon Aguiar notifications@github.com
wrote:

Thanks for the response @jmarantz https://github.com/jmarantz, when I
disabled the "cache_extend" the images are showing, but they aren't
compressed.
Take a look at http://www.ofertasdeemail.com.br/

The image "
http://cf-static.ofertasdeemail.com.br/banners/oferta-do-dia-americanas-03-06-2015-3.jpg"
isn't being compressed.


Reply to this email directly or view it on GitHub
#43 (comment)
.

@herlon214

This comment has been minimized.

herlon214 commented Jun 3, 2015

I'm sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment