Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle BOMs in JS better when combining #446

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 0 comments
Closed

Handle BOMs in JS better when combining #446

GoogleCodeExporter opened this issue Apr 6, 2015 · 0 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

BOMs were being treated as just part of the JS when combining, without taking 
into account what it meant regarding the JS's charset. This means we could 
combined JS with different charsets, giving an unparseable result.

The fix is to determine the charset of the JS and only combine candidates that 
have the same charset as the current combination.

Original issue reported on code.google.com by matterb...@google.com on 23 May 2012 at 1:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.