Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable sharding when running under SPDY in general, mod_spdy in particular #450

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 9 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Currently mod_pagespped and mod_spdy separate on the issue of sharding. 
mod_pagespeed wants to shard assets so as to increase parallel downloading. 
mod_spdy, implementing the SPDY protocol, wants all the content on one domain 
under SSL. I have fudged this setup so as not to get sharding on a SPDY URL, 
but it wasn't great.

A better way would be that there is a shardIfNotSpdy or similar setting. 
mod_pagespeed then will not shard content with domain rewrites if the request 
is a SPDY request (in Apache this is available via the  SPDY_VERSION 
environmental var).

Original issue reported on code.google.com by shri...@gmail.com on 13 Jun 2012 at 8:27

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Yes we are aware of the conflict between the transformations done by 
mod_pagespeed and the best practice for SPDY.  We would like to make 
mod_pagespeed work extremely well with mod_spdy and there's a lot of pieces of 
this.

But I think it might be nice to enumerate them individually so I'm going to 
rename this bug to disable sharding for SPDY protocol.

Summary was: mod_pagespeed should play nicely with mod_spdy

Original comment by jmara...@google.com on 13 Jun 2012 at 1:58

  • Changed title: disable sharding when running under SPDY in general, mod_spdy in particular
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

I agree with the renaming. Just to let you know that this is achievable in 
Apache 2.4 by the use of <If> for enabling mod_pagespeed with particular 
filters enabled/disabled. Doing this in 2.2 is not possible.

Original comment by shri...@gmail.com on 13 Jun 2012 at 2:04

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Hmm. I think having us conditionally do sharding for http-only is also helpful 
when it comes to our backend fetches, as not having any shards before us makes 
it easier to figure out how to fetch stuff.

Original comment by morlov...@google.com on 15 Jun 2012 at 8:44

  • Changed state: Accepted
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

As of r2017, trunk lets you put modpagespeed options inside 
<ModPagespeedIf spdy> and <ModPagespeedIf !spdy> sections. 
Putting the sharding commands into <ModPagespeedIf !spdy> will 
cover this particular usecase.

Original comment by morlov...@google.com on 1 Oct 2012 at 11:02

  • Added labels: Milestone-v23
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by morlov...@google.com on 23 Oct 2012 at 2:05

  • Added labels: release-note
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

This is good. Not quite as good as to crush your enemies, see them driven 
before you, and to hear the lamentation of their women. But it is good.

Original comment by shri...@gmail.com on 24 Oct 2012 at 11:53

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by j...@google.com on 26 Oct 2012 at 3:05

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

I left this open on purpose since I didn't write the docs yet...

Original comment by morlov...@google.com on 26 Oct 2012 at 3:09

  • Changed state: Started
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Docs staged (will be pushed once a version with the code is part of a release)

Original comment by morlov...@google.com on 5 Nov 2012 at 3:06

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.