New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defer_javascript should turn off for requests with header XMLHttpRequest #480

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

From amattie@gmail.com:


I think defer_javascript should automatically disable when the request contains 
a "X-Requested-With: XMLHttpRequest" header or a "Origin" header w/ any value. 
The reasoning is that any content placed on the page by XmlHttpRequest will 
have the expectation that the script will run as soon as it's on the page; in 
the current implementation, those script tags don't appear to run at all.

Like I said earlier, defer_javascript looks very promising and we're excited to 
eventually be able to use it. It appears to speed up rendering significantly; I 
wouldn't have bothered with investigating issues otherwise!

Original issue reported on code.google.com by jmara...@google.com on 27 Jul 2012 at 9:50

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This is already the case for the generic implementation in ProxyInterface, but 
not in Apache. 

+sligocki, as it might affect his refactoring strategy. 

Original comment by morlov...@google.com on 30 Jul 2012 at 2:12

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 15 Aug 2012 at 12:48

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 15 Aug 2012 at 12:50

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Kishore -- is this done already?

Original comment by jmara...@google.com on 30 Oct 2012 at 9:57

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

This is done. Can you please close issue.

Original comment by ksimb...@google.com on 30 Oct 2012 at 10:19

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 30 Oct 2012 at 10:26

  • Changed state: Fixed
  • Added labels: Milestone-v23, release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment