New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is trim_urls in core filter set? #493

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

Top of this page lists "trim_urls" as part of the core filters:
https://developers.google.com/speed/docs/mod_pagespeed/config_filters

Scroll further down, to the table listing each filter in turn, and it says:
trim_urls   No  Shortens URLs by making them relative to the base URL. 

The No is in the "In Core Set" column. Probably a documentation bug.

Original issue reported on code.google.com by callum.m...@gmail.com on 12 Sep 2012 at 2:27

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

The answer is: right now, yes it's a core filter, but that's a mistake.
A near-future release will remove it from the core set, and THANKS for pointing 
out that the doc needs correction.

Original comment by matterb...@google.com on 12 Sep 2012 at 2:39

  • Changed state: Accepted
  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Clarification: it's NOT a core filter in any recent packaged release, only in 
source releases after 0.10.22.6.

Original comment by matterb...@google.com on 12 Sep 2012 at 2:44

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

I have verified that the online doc has been corrected.

Original comment by matterb...@google.com on 30 Oct 2012 at 8:51

  • Changed state: Fixed
  • Added labels: Milestone-v23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment