New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirtualHosts should inherit configuration from root #495

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

It is more cumbersome that necessary to use MPS with virtual hosts.  I think we 
should add a configuration-merging function to pagespeed_module.  Note the TODO 
in that code now at the bottom of mod_instaweb.cc

  NULL,  // TODO(jmarantz): merge root/VirtualHost configs via merge_dir_config.


Duncan's suggestion is to have a new .conf directive which turns on 
configuration-merging.  This should be feasible.  We could also default-this to 
"off" in C++ and turn it on in the default pagespeed.conf so that new users get 
the easier-to-use version.

Original issue reported on code.google.com by jmara...@google.com on 14 Sep 2012 at 12:48

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 17 Sep 2012 at 7:30

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 17 Sep 2012 at 7:32

  • Added labels: Milestone-v23
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Code in in r1978. Still need docs.

Original comment by morlov...@google.com on 25 Sep 2012 at 2:28

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Docs staged (will be pushed once a version with the code is part of a release)

Original comment by morlov...@google.com on 5 Nov 2012 at 4:38

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment