New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page load count based on actual HTML rewrites (not beacon count) #499

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

Implement an internal counter for HTML pages handled by Pagespeed.
The current Page Load metric is based on beacon data but this would be an 
counter internal to Pagespeed that would always be available.

Original issue reported on code.google.com by hayes...@gmail.com on 18 Sep 2012 at 7:24

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Does per-vhost mod_pagespeed_statistics work for your needs? I believe that is 
already implemented in trunk.

Original comment by sligocki@google.com on 18 Sep 2012 at 1:09

  • Changed state: RequestClarification
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

The issue is that we don't have a stat on number of html pages rewritten.

Original comment by morlov...@google.com on 18 Sep 2012 at 1:11

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Summary was: Page Load metrics per VHOST

Oh, geez, I didn't realize page_load_count was really beacon count. Got it. We 
should probably rename these to be a bit more intuitively named as well.

Original comment by sligocki@google.com on 18 Sep 2012 at 1:23

  • Changed title: Page load count based on actual HTML rewrites (not beacon count)
  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Should be fixed in trunk in r1953.

We should now be counting the total number of HTML rewrites in 
total_rewrite_count.

Original comment by sligocki@google.com on 19 Sep 2012 at 10:35

  • Changed state: Fixed
  • Added labels: release-note
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by j...@google.com on 26 Oct 2012 at 5:50

  • Added labels: Milestone-v23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment