New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS Filter: Incorrectly minification not-quoted font-family names with spaces #5

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

this style:
font-family: trebuchet ms;

is being minified to:
font-family: trebuchetms;

while it should be:
font-family: "trebuchet ms";
or remain untouched


Original issue reported on code.google.com by cgeorgak...@gmail.com on 3 Nov 2010 at 10:24

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Ah, that's not right. Thanks for the report, I'm looking into it.

Original comment by sligocki@google.com on 3 Nov 2010 at 11:24

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 5 Nov 2010 at 3:01

  • Added labels: Priority-Critical
  • Removed labels: Priority-Medium
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

http://code.google.com/p/modpagespeed/source/detail?r=146

Note: this fix has not been made available in binary form yet.  We will release 
new binary distributions incorporating these changes on Monday Nov 8.

Those building using the open-source instructions on 
http://code.google.com/p/modpagespeed/wiki/HowToBuild can try out these 
improvements immediately.

Original comment by jmara...@google.com on 5 Nov 2010 at 10:50

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

To clarify, we've turned off CSS minification by default because it is 
dangerous. We still need to fix this bug so that we can minify CSS correctly.

Original comment by sligocki@google.com on 5 Nov 2010 at 11:16

  • Changed state: Accepted
  • Added labels: Priority-High
  • Removed labels: Priority-Critical
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 10 Nov 2010 at 8:10

  • Changed title: CSS Filter: Incorrectly minification not-quoted font-family names with spaces
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Looks like this is fixed in head. I've added a test for it as well.

Original comment by sligocki@google.com on 10 Nov 2010 at 9:45

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment