New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

large numbers get rewritten to scientific notation #508

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Use a large z-index (inexperienced or sloppy CSS coders will do that), like 
"z-index:10000000000000000;"
2. Pull through mod_pagespeed.

What is the expected output? What do you see instead?

Output: 
"z-index: 1e+16;"
Expected output:
"z-index:10000000000000000;"

What version of the product are you using (please check X-Mod-Pagespeed
header)?
Don't know, no X-Mod-Pagespeed header

On what operating system?
Ubuntu

Which version of Apache?
2.2.16

Which MPM?
No idea what this is, sorry :-)

URL of broken page:
http://flow.proquest.com/public/css/I.library.css+collaboration.css+oz,,_library
.css+biblio.css+oz,,_frame-app.css,Mcc.Ge-J1ldCoY.css.pagespeed.cf.rYKo0GSKba.cs
s


Original issue reported on code.google.com by taco.ek...@gmail.com on 28 Sep 2012 at 9:28

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I looked at http://flow.proquest.com and noticed it's definitely serving 
mod_pagespeed-optimized content, but does not have X-Mod-Pagespeed headers.

taco.ekkel: this is not apropos of your problem, but do you know why that is?  
Do you run mod_pagespeed on an Apache server that sits behind another proxy and 
strips all but a known set of headers?

Original comment by jmara...@google.com on 28 Sep 2012 at 1:10

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Yes, this is a known problem that we were hoping wouldn't affect users (because 
you need really big numbers for it to matter). Is this breaking your site, or 
just causing confusing notation?

The linked URL seems to have much saner values now :)

Original comment by sligocki@google.com on 31 Oct 2012 at 8:48

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 31 Oct 2012 at 8:48

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Heh, it helped us fix our site, actually. You might want to keep it just to 
punish bad CSS :-) But yes, this was breaking — browsers do not accept 
scientific notation, so they'll ignore the CSS statement instead.

Yes, the apache sits behind an amazon AWS load balancer which may strip headers 
out, I don't know exactly. If it's important I can dig in, ask around etc.

Original comment by taco.ek...@gmail.com on 31 Oct 2012 at 10:39

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r2765.

Original comment by sligocki@google.com on 4 Apr 2013 at 7:47

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 4 Apr 2013 at 7:49

  • Added labels: Milestone-r27, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by sligocki@google.com on 4 Apr 2013 at 7:50

  • Added labels: Milestone-v27
  • Removed labels: Milestone-r27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment