Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite_css removes rgba color values #51

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

rewrite_css removes rgba color values #51

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Using 0.9.0.0-128, the rewrite_css filter messes up rgba color values.

This CSS:

box-shadow: -1px -2px 2px rgba(0, 0, 0, .15);


is changed to be this:

box-shadow:-1px -2px 2px rgba();


Thanks!

Original issue reported on code.google.com by joe.lencioni on 8 Nov 2010 at 8:39

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Thanks for the distilled example, I'll look into this.

Original comment by sligocki@google.com on 8 Nov 2010 at 8:49

  • Added labels: Priority-High
  • Removed labels: Priority-Medium
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

As with bug 50, this is a CSS3 syntax we don't parse yet. I'll look into not 
breaking this though. And please post any other breakages we cause.

Thanks,
-Shawn

Original comment by sligocki@google.com on 9 Nov 2010 at 3:38

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Will do, thanks!

Original comment by joe.lencioni on 9 Nov 2010 at 3:40

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

These should be fixed by 
http://code.google.com/p/modpagespeed/source/detail?r=175 which also adds 
checks for this situation.

If you build from source, please let me know if this fixes you. If you install 
from binary, we'll send an announcement to the list when the next binary is 
released.

Thanks for the fix Yi-An!

Original comment by sligocki@google.com on 9 Nov 2010 at 11:17

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.