New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

combine_css breaks background image url due to mis-handling of quotes. #60

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 5 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter

GoogleCodeExporter commented Apr 6, 2015

chris@chrisbeach.co.uk is finding that this:

div#footer { background-image: url( '/images/layout/footerBG.jpg' );
background-repeat: no-repeat }

...gets rewritten to this:

div#footer { background-image: url(http://www.captioncompetition.co.uk/
coreCaption/'/images/layout/footerBG.jpg'); background-repeat: no-
repeat }

...which breaks the image unfortunately

Original issue reported on code.google.com by jmara...@google.com on 9 Nov 2010 at 3:10

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Thanks for the bug report.  This should not be hard to fix.

Original comment by jmara...@google.com on 9 Nov 2010 at 3:11

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

There are two immediate-term workarounds:

1. remove the spaces, e.g.  
            use               url('/images/layout/footerBG.jpg')
            rather than       url( '/images/layout/footerBG.jpg' )
2. Temporarily disable filter combine_css

Original comment by jmara...@google.com on 9 Nov 2010 at 3:18

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Sorry for the delay -- the fix made and will be in the next binary release.  
Will update this bug when the fix is submitted to SVN.

Original comment by jmara...@google.com on 19 Nov 2010 at 2:08

@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Fixed in http://code.google.com/p/modpagespeed/source/detail?r=232

Original comment by jmara...@google.com on 19 Nov 2010 at 4:05

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

GoogleCodeExporter commented Apr 6, 2015

Issue 119 has been merged into this issue.

Original comment by jmara...@google.com on 1 Dec 2010 at 11:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment