New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxied resources aren't combined with local resources #600

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 10 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

It appears that resources proxied with ModPagespeedMapProxyDomain aren't 
combined with local resources. Take a look at the following config / HTML:

ModPagespeedMapProxyDomain http://foo.com/bar-static http://bar.com/static

<head>
<link rel="stylesheet" href="//foo.com/1.css" />
<link rel="stylesheet" href="//foo.com/2.css" />
<link rel="stylesheet" href="//bar.com/static/a.css" />
<link rel="stylesheet" href="//foo.com/3.css" />
<link rel="stylesheet" href="//foo.com/4.css" />
</head>

In that case, 1.css and 2.css will be processed and combined, static/a.css will 
be proxied and processed, and 3.css and 4.css will be processed and combined. 
That leaves 3 resources for browsers to fetch. Ideally the proxied resource 
wouldn't interrupt the combiner and thus there'd only be one resource to 
download.

Using v1.2.24.1 w/ Apache 2.2 w/ prefork.

Original issue reported on code.google.com by amat...@gmail.com on 3 Jan 2013 at 7:22

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Just a quick check: do you have ModPagespeedCombineAcrossPaths turned off?

If not, it's probably a simple problem on our side to fix.

Original comment by jmara...@google.com on 3 Jan 2013 at 7:30

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Nope. Didn't touch ModPagespeedCombineAcrossPaths. Because of issue 599, I also 
tested this independent of our CDN by disabling MapRewriteDomain.

Original comment by amat...@gmail.com on 3 Jan 2013 at 7:34

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Oh, one more thing.  Can you try it again but append

    ?ModPagespeedFilters=+debug

This will annotate why the CSS files didn't get combined as comments in the 
HTML output.

Original comment by jmara...@google.com on 3 Jan 2013 at 7:42

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 3 Jan 2013 at 7:59

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I see this additional comment at the end of my HTML when I add +debug:

<!--css_combine: end_document--><!--
#NumFlushes            0
#EndDocument after     115393us
#Total Parse duration  2078us
#Total Render duration 7181us
#Total Idle duration   113315us
-->

I don't see anything at all related to the combiner in my Apache log when I 
turn on that directive -- even with "LogLevel debug". I do see two 
mod_pagespeed errors relating to an image that's referenced somewhere (prob in 
CSS) not being found, but that's it as far as errors go.

Original comment by amat...@gmail.com on 3 Jan 2013 at 9:42

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I'll try to reproduce this bug and see what's going on on Monday.

Original comment by jkar...@google.com on 4 Jan 2013 at 8:01

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

[deleted comment]
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I've confirmed the bug and have a working solution.

Original comment by jkar...@google.com on 7 Jan 2013 at 4:35

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This is now fixed in subversion and your example should work.

Original comment by jkar...@google.com on 10 Jan 2013 at 6:56

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by morlov...@google.com on 12 Feb 2013 at 8:08

  • Added labels: Milestone-v25, release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment