New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitializeNested in CssHierarchy initializes a stringpiece with too wide a scope #601

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

The url_ variable scoped to CssHierarchy in Initalizenested is sometimes 
initialized with a stack scoped string (See calling functions to confirm this) 
If the stack scoped string is destroyed the url_ points to invalid data, this 
may or may not cause a crash in further processing.

Fix: make url_ a GoogleString, GoogleUrl or initialize a secondary variable.

Original issue reported on code.google.com by kspoels...@we-amp.com on 7 Jan 2013 at 9:05

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Good catch.  Did you find this via valgrind or something?

Original comment by jmara...@google.com on 7 Jan 2013 at 9:12

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

No, :(, a css file was not loaded in the tests, a lot of old fashioned tracing 
and debugging followed ...

Original comment by kspoels...@we-amp.com on 9 Jan 2013 at 6:15

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This is fixed in r2452. Are you able to build from source and try again?
Thanks!

Original comment by matterb...@google.com on 30 Jan 2013 at 5:43

  • Changed state: Fixed
  • Added labels: Milestone-v25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment