New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quoting of ModPagespeed:noscript insertion broken in some browsers #627

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 28 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

Hmm some interesting entries in my log today:

[Sat Feb 23 13:59:42 2013] [warn] [mod_pagespeed 1.3.25.2-2530 @11639] Invalid 
value for ModPagespeed: noscript'%22 (should be on, off, unplugged, or noscript)
[Sat Feb 23 13:59:42 2013] [warn] [mod_pagespeed 1.3.25.2-2530 @11639] Invalid 
ModPagespeed query params or headers for request 
http://www.sellmyretro.com/'http://www.sellmyretro.com/?ModPagespeed=noscript'%2
2. Serving with default options.
[Sat Feb 23 13:59:42 2013] [warn] [mod_pagespeed 1.3.25.2-2530 @11639] Invalid 
value for ModPagespeed: noscript'%22 (should be on, off, unplugged, or noscript)

ModPagespeed is working fine on the site - www.sellmyretro.com

I have not seen these errors before - any ideas what caused them?
At the time, I could not access the site for about a minute...

Original issue reported on code.google.com by rwap.services on 23 Feb 2013 at 3:50

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Summary Was: Odd error_log entries

Original comment by jmara...@google.com on 24 Feb 2013 at 2:51

  • Changed title: Quoting of ModPagespeed:noscript insertion broken in some browsers
  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 4 Mar 2013 at 7:59

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I have one as well

Invalid value for ModPagespeed: noscript' (should be on or off)

Original comment by spcmnetw...@gmail.com on 29 Mar 2013 at 3:28

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Any idea on what UA the users that see the problem are seeing? I am not able to 
reproduce this with anything I tried...

Original comment by morlov...@google.com on 2 Apr 2013 at 3:21

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

My access log for the time of one of these errors shows:

42.121.31.177 - - [31/Mar/2013:07:37:44 +0100] "GET 
/phpbb/?ModPagespeed=noscript/viewforum.php?f=3&sid=52361ca8e01dbb3d0b5c132faf68
1f8a HTTP/1.0" 200 14083 
"http://www.sellmyretro.com/viewforum.php?f=3&sid=52361ca8e01dbb3d0b5c132faf681f
8a" "Opera/9.80 (Windows NT 6.0) Presto/2.12.388 Version/12.10"

Whether that is a real version of Opera or something pretending to be Opera - 
who knows!

Original comment by rwap.services on 3 Apr 2013 at 7:06

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Is there no entry with the broken 
http://www.sellmyretro.com/'http://www.sellmyretro.com/?ModPagespeed=noscript'%2
2 url?

Original comment by morlov...@google.com on 3 Apr 2013 at 1:42

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Unfortunately, I don't have the original access logs from 28th February - 
however the above access log entry (comment #5) relates to an entry in the 
error log:

[Sun Mar 31 07:37:44 2013] [warn] [mod_pagespeed 1.3.25.4-2630 @2707] Invalid 
value for ModPagespeed: noscript/viewforum.php?f=3 (should be on, off, 
unplugged, or noscript)


Looking at the URL in the access log - I wonder what is inserting the 
?ModPagespeed=noscript before the remainder of the URL - rather than after the 
last parameter?

Original comment by rwap.services on 3 Apr 2013 at 2:34

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Similar error reported by another user

[Mon Apr 15 08:10:05 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @370279] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2011/05/29/percentage-off-milanoo-8/?ModPagespeed=noscript%5C%2
7. Serving with default options.
[Mon Apr 15 08:10:05 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @370279] Invalid 
value for ModPagespeed: noscript%5C%27 (should be on, off, unplugged, or 
noscript)
[Mon Apr 15 08:10:05 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @370279] Invalid 
value for ModPagespeed: noscript%5C%27 (should be on, off, unplugged, or 
noscript)

Original comment by j...@google.com on 15 Apr 2013 at 2:56

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Here are more logs 
Apache Main Error Log
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @556821] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @556821] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27. Serving 
with default options.
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @556821] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @556821] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27. Serving 
with default options.
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscrip
t%27. Serving with default options.
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscrip
t%27. Serving with default options.
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @518026] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27. Serving 
with default options.
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:09 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27. Serving 
with default options.
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscrip
t%27. Serving with default options.
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
ModPagespeed query params or headers for request 
http://icnd.info/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscrip
t%27. Serving with default options.
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)
[Tue Apr 16 02:20:10 2013] [warn] [mod_pagespeed 1.5.27.0-2800 @513858] Invalid 
value for ModPagespeed: noscript%27 (should be on, off, unplugged, or noscript)


Domains Apache error log
[Tue Apr 16 02:20:09 2013] [warn] [client ip.address] Request not rewritten 
because ModPagespeed query-params or headers are invalid.
[Tue Apr 16 02:20:09 2013] [warn] [client ip.address] Request not rewritten 
because ModPagespeed query-params or headers are invalid.
[Tue Apr 16 02:20:10 2013] [warn] [client ip.address] Request not rewritten 
because ModPagespeed query-params or headers are invalid.
[Tue Apr 16 02:20:10 2013] [warn] [client ip.address] Request not rewritten 
because ModPagespeed query-params or headers are invalid.

Domains Apache Access log
same.ip - - [16/Apr/2013:02:20:09 -0500] "HEAD 
/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info/2013/04/15/perc
entage-off-homerunmonkey-3/?ModPagespeed=noscript%27 HTTP/1.1" 301 - "-" "-"
same.ip - - [16/Apr/2013:02:20:09 -0500] "HEAD 
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27 HTTP/1.1" 
200 - "-" "-"
same.ip - - [16/Apr/2013:02:20:09 -0500] "GET 
/2013/04/15/percentage-off-homerunmonkey-3/%27http%3A//icnd.info/2013/04/15/perc
entage-off-homerunmonkey-3/?ModPagespeed=noscript%27 HTTP/1.1" 301 - "-" "-"
same.ip - - [16/Apr/2013:02:20:10 -0500] "GET 
/2013/04/15/percentage-off-homerunmonkey-3/?ModPagespeed=noscript%27 HTTP/1.1" 
200 26060 "-" "-"

Original comment by Nandrajo...@gmail.com on 16 Apr 2013 at 8:25

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Wonder why one of my previous comments with logs was deleted?

Original comment by Nandrajo...@gmail.com on 23 Apr 2013 at 3:41

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Hello, any news?
I have the same issue displayed in apache error_log:

[Fri Oct 18 22:43:14 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @17888] Invalid 
ModPagespeed query params or headers for request 
http://www.almanaqueculinario.com.br/receita/ganso-assado-para-ceia-995?ModPages
peed=noscript'. Serving with default options.
[Fri Oct 18 22:43:16 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @17888] Invalid 
value for ModPagespeed: noscript' (should be on, off, unplugged, or noscript)
[Fri Oct 18 22:43:16 2013] [warn] [client 127.0.0.1] Request not rewritten 
because ModPagespeed query-params or headers are invalid.

In my .htaccess:
ModPagespeedSupportNoScriptEnabled off

I dont wanna to use noscript tags in html.
Tnks!

Original comment by diog...@gmail.com on 19 Oct 2013 at 1:55

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

[deleted comment]
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Have any way to disable this warn that is filling error_log?

Original comment by diog...@gmail.com on 19 Oct 2013 at 1:49

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

ModPagespeedSupportNoScriptEnabled off should work fine in .htaccess files.  I 
am not seeing a noscript redirect on your page now.

Maybe you noticed some warnings after you added it to the htaccess file because 
you support caching of HTML and so your downstream cache trapped the 
noscript-instrumented version of HTML for 86400 seconds (1 day). 

Can you flush your error log and check again?

Also, as noted before, it would be very useful if you could tell us what 
user-agent is sending back the broken noscript request so we could debug with 
it.

Original comment by jmara...@google.com on 19 Oct 2013 at 6:49

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Thanks for reply.

I will wait until tomorrow to see if warn will completely disappear from 
erro_log. Some user agent entrys from apache access_log:

127.0.0.1 - - [19/Oct/2013:03:26:41 -0300] "GET 
/receita/massas/talharim-com-molho-rose-e-camaro-28732.html?ModPagespeed=noscrip
t' HTTP/1.1" 301 393 "-" "Mozilla/5.0 (compatible; bingbot/2.0; 
+http://www.bing.com/bingbot.htm)"

127.0.0.1 - - [19/Oct/2013:03:27:45 -0300] "GET 
/receita/lanches-e-salgadinhos/salgadinho-de-queijo-19143.html?ModPagespeed=nosc
ript' HTTP/1.1" 301 381 "-" "Mozilla/5.0 (compatible; Googlebot/2.1; 
+http://www.google.com/bot.html)"

127.0.0.1 - - [19/Oct/2013:20:16:30 -0300] "GET 
/receita/prato-unico/fusili-com-braciola-5393.html?ModPagespeed=noscript' 
HTTP/1.1" 301 379 "-" "Mozilla/5.0 (compatible; YandexBot/3.0; 
+http://yandex.com/bots)"

127.0.0.1 - - [19/Oct/2013:20:16:41 -0300] "GET 
/receita/creme-chines-da-pami-14049?ModPagespeed=noscript' HTTP/1.1" 200 31374 
"-" "Mozilla/5.0 (compatible; Googlebot/2.1; +http://www.google.com/bot.html)"

The problem at the moment is the number of entries filling the error_log. Do 
you recommend something?

Original comment by diog...@gmail.com on 19 Oct 2013 at 11:27

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Can you try flushing your cache -- the one that (in my theory anyway) is 
holding the HTML with the noscript meta-tag?

I say that this is just my theory because when I look at 
view-source:http://www.almanaqueculinario.com.br/receita/ganso-assado-para-ceia-
995 I don't see any noscript redirect.

Maybe this is happening in a cache you don't control.

I don't have any current ideas about how to squelch the error log.

Those BOT entries all have the extra quote, it seems.

Original comment by jmara...@google.com on 20 Oct 2013 at 12:07

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Yes, i flushed all the cache yesterday, you will not see any page with noscript 
redirect.
I belive that this cache was only in bots (like you said, i dont control).

As I said earlier, I will wait a few days to see if these entries disappear 
(anything notice here). But in any case, thank you very much for help.


Original comment by diog...@gmail.com on 20 Oct 2013 at 12:21

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Entries are slowly disappearing from the error_log, following a tip as this 
number decreases. Put in your robots.txt:

User-agent: *
Disallow: /*?ModPagespeed=

Hope that helps.

Original comment by diog...@gmail.com on 29 Oct 2013 at 1:28

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Could you confirm whether the noscript warnings have stopped filling your logs 
now that you've turned them off?

Original comment by jmara...@google.com on 13 Nov 2013 at 3:26

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Decreased but not stopped completely, and Google does not seem to respect the 
robots.txt continuing indexing and displaying old pages with ?ModPagespeed=. 
Check in:

https://www.google.com.br/search?q=site%3Aalmanaqueculinario.com.br+inurl%3A%3FM
odPagespeed

Because we uses Google Custom Search Engine, users end up accessing these old 
urls that generate these log entries.

Last error_log entries:

[Wed Nov 13 07:22:31 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @28015] Invalid 
value for ModPagespeed: noscript' (should be on, off, unplugged, or noscript)

[Wed Nov 13 07:22:31 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @28015] Invalid 
ModPagespeed query params or headers for request 
http://www.almanaqueculinario.com.br/receita/risoto-del-mare-360?ModPagespeed=no
script'. Serving with default options.

[Wed Nov 13 07:22:31 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @28015] Invalid 
value for ModPagespeed: noscript' (should be on, off, unplugged, or noscript)

[Wed Nov 13 07:22:31 2013] [warn] [mod_pagespeed 1.4.26.4-3396 @28015] Invalid 
ModPagespeed query params or headers for request 
http://www.almanaqueculinario.com.br/receita/risoto-del-mare-360?ModPagespeed=no
script'. Serving with default options.

PS: Since September 4 had a decrease of 90% of the site traffic (from Google, 
all keywords), I do not know if it would be the reason for this urls which 
generates indexing duplicate content. No manual action was found in GW. Always 
use the canonical tag on every page.

Original comment by diog...@gmail.com on 13 Nov 2013 at 4:40

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I am going to fix this by resurrecting an old proposed change where we would 
simply ignore spurious quotes.

Original comment by jmara...@google.com on 13 Nov 2013 at 9:02

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Thank you so much jmara!

Original comment by diog...@gmail.com on 14 Nov 2013 at 1:29

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Fixed in https://code.google.com/p/modpagespeed/source/detail?r=3633

Original comment by jmara...@google.com on 16 Nov 2013 at 12:04

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 16 Nov 2013 at 12:04

  • Added labels: Milestone-v31, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

When this fix will be release, avaliable in stable version? How the releases of 
the new versions works? First are available in beta versions and then to 
stable? Thnks.

Original comment by diog...@gmail.com on 29 Nov 2013 at 4:14

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I just noticed yesterday about this two messages. It keeps repeating if someone 
access a randomized valid link on my page such as follows (the link is faked on 
this instance). How to solved this error message? :)

Here's the quote:
[Mon Mar 10 09:02:19 2014] [warn] [mod_pagespeed 1.6.29.7-3566 @2282] Invalid 
PageSpeed query params or headers for request 
https://www.somedomain/'https://www.somedomain/aaa/bbb/ccc/kke4J-B13sD8FYzoIzbws
m3lScuolkVncbc3AG_ymXNrKHYpWMcRs_T63fOBrsRB1ZKNRJFb4vMIINU74EhW4A,,?ModPagespeed
=noscript'. Serving with default options.
[Mon Mar 10 09:02:19 2014] [warn] [mod_pagespeed 1.6.29.7-3566 @2282] Invalid 
value for ModPagespeed: noscript' (should be on, off, unplugged, or noscript)

[Tue Mar 11 10:22:20 2014] [warn] [mod_pagespeed 1.6.29.7-3566 @24117] Invalid 
PageSpeed query params or headers for request 
https://www.somedomain/aaa/bbb/ccc/ZjOP_nZp3prvLhl1ANnVkHWmTvfhPX5p9O7podHVVXCau
yoRVG1kehCLjO5A2SVlqDzH8DgS_fkqv9Vhl0xSvg,,?ModPagespeed=abfpevcg%27. Serving 
with default options.
[Tue Mar 11 10:22:21 2014] [warn] [mod_pagespeed 1.6.29.7-3566 @24117] Invalid 
value for ModPagespeed: abfpevcg%27 (should be on, off, unplugged, or noscript)
[Tue Mar 11 10:22:21 2014] [warn] [client 192.168.1.97] Request not rewritten 
because PageSpeed query-params or headers are invalid.

Original comment by charlesa...@gmail.com on 11 Mar 2014 at 4:11

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Charlessa,

Update to Release 1.7.30.2-beta, check fixed issues in 
https://developers.google.com/speed/pagespeed/module/release_notes

Original comment by diog...@gmail.com on 11 Mar 2014 at 1:20

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Thx dude, I'll give it a try. :)

Original comment by charlesa...@gmail.com on 11 Mar 2014 at 2:20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment