New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazyload Images Defect on Blackberry Browser w/ OS <= 5 #641

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 8 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?
1. Enable this filter --> lazyload_images 
(https://developers.google.com/speed/docs/mod_pagespeed/filter-lazyload-images)

What is the expected output? What do you see instead?
The images didn't showing, because the blackberry browser on OS 5 below aren't 
supported by default. See 
https://www.google.com/search?q=javascript+support+blackberry+os+5

What version of the product are you using (please check X-Mod-Pagespeed
header)?
mod-pagespeed-beta-1.3.25.3-2556.x86_64

On what operating system?
CentOS 6.3

Which version of Apache?
Server version: Apache/2.2.15 (Unix)

Which MPM?
*don't know*

URL of broken page:
http://www.lintas.me

Original issue reported on code.google.com by dewangg...@xtremenitro.org on 9 Mar 2013 at 7:22

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Sorry I forgot something, maybe it can be inserted into 
https://code.google.com/p/modpagespeed/source/browse/trunk/src/net/instaweb/http
/user_agent_matcher.cc and blacklist using lazyload filter on older blackberry 
browser (eg. below OS 5)

Thank you :)

Original comment by dewangg...@xtremenitro.org on 9 Mar 2013 at 7:23

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

I'm curious: does BlackBerry not run JavaScript, and also not support running 
the blocks in <noscript>?

Anyway you found a good spot to inject a real fix.  There's also a possible 
workaround using SeteEnvIf

   SetEnvIf User-Agent UA_BlackBerry_5 mps_core_only
   RequestHeader set ModPagespeedFilters core env=mps_core_only

Can you share with us what the UA for BlackBerry v5 is?

Original comment by jmara...@google.com on 9 Mar 2013 at 9:08

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Hello Josh,

Blackberry could run javascript, but not all the functions works well. (eg. 
LazyLoad) I don't know why the browser didn't response the <noscript> 's blocks.

Anyway, easily I found it from the blackberry support 
http://supportforums.blackberry.com/t5/Web-and-WebWorks-Development/How-to-detec
t-the-BlackBerry-Browser/ta-p/559862

For sure, here is some UA from Blackberry with OS 5 or less at my AccessLog

- BlackBerry9700/5.0.0.1014 Profile/MIDP-2.1 Configuration/CLDC-1.1 VendorID/613
- BlackBerry9700/5.0.0.593 Profile/MIDP-2.1 Configuration/CLDC-1.1 VendorID/613
- BlackBerry8520/5.0.0.1075 Profile/MIDP-2.1 Configuration/CLDC-1.1 VendorID/613
- BlackBerry8520/5.0.0.1036 Profile/MIDP-2.1 Configuration/CLDC-1.1 VendorID/125
- BlackBerry8110/4.5.0.52 Profile/MIDP-2.0 Configuration/CLDC-1.1 VendorID/120
And a lot of lines :D

Since the Blackberry Browser on OS v6.x or latest, lazyload filter is works 
perfect.
Can I set the SetEnvIf using regular expression? Because every blackberry 
device have many OS version. (see the example above)

Original comment by dewangg...@xtremenitro.org on 10 Mar 2013 at 3:22

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 11 Mar 2013 at 6:58

  • Changed state: Accepted
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r2620.

Original comment by j...@google.com on 18 Mar 2013 at 10:38

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by j...@google.com on 18 Mar 2013 at 10:41

  • Added labels: Milestone-v26
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This will be a fixed in an upcoming patch to 1.3.25 by excluding lazyload from 
running for old blackberry versions. If you are able to debug the lazyload JS 
for blackberry and figure out why it doesn't work, we'd welcome that input.

Original comment by j...@google.com on 19 Mar 2013 at 6:11

  • Added labels: Milestone-v25
  • Removed labels: Milestone-v26
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Cool, 

Talk about why the lazy load can't shows normally on old blackberry devices, we 
should confirm to Blackberry Developer. I'll try to follow up this issue and 
report back to you J.

Regards,

Original comment by dewangg...@xtremenitro.org on 20 Mar 2013 at 5:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment