New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images inlined for CSS inlines in HTML even when CssImageInlineMaxBytes is zero #650

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 1 comment

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

What steps will reproduce the problem?

1. Set CssImageInlineMaxBytes to zero.
2. Leave ImageInlineMaxBytes at the default of 2048.
3. Load a page that has inline CSS with images smaller than 2048 bytes.

What is the expected output? What do you see instead?

    The images should not inline, however, they do.

Please use labels and text to provide additional information.

The prioritize_critical_css needs to have image inlining applied consistently 
between CSS inlined in HTML and external CSS files.

Proposal: In inline CSS, only inline an image if it is smaller than both 
ImageInlineMaxBytes and CssImageInlineMaxBytes.

The planned fix will also update the documentation.


Original issue reported on code.google.com by sl...@google.com on 19 Mar 2013 at 4:22

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Fixed in r2631.

Original comment by sl...@google.com on 19 Mar 2013 at 9:40

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment