New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add originating page URL query-param to beacon URL #690

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 6 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

This will help sites that want to send all beacons for a page to the same 
physical server as the one that will handle the HTML.

Note that we do send the encoded URL as a post parameter, but the 
load-balancing is much easier to do if it's available as a query-param.


It would be preferable to remove the post-body param and rely solely on the 
query-param for transmitting the URL.  If you don't do this, then I think we'll 
need a new pagespeed.conf option to additionally add the URL as a query-param.  
But if that's easier for some reason then it seems acceptable.

Original issue reported on code.google.com by jmara...@google.com on 8 May 2013 at 7:41

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

From a configurability standpoint, having the ability to set the param name 
would be ideal in cases where we need to give it a unique namespace.

So two configs:
1) Enable URL Query Param
2) Set param name to X

Does the pixel file name and extension remain consistent over time?

Original comment by hayes...@gmail.com on 9 May 2013 at 6:43

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

We'll have a change checked in shortly to add the originating page url to the 
beacon.

Regarding the second config option (setting the param name), does it need to be 
the same param as the URL? We already have an option ModPagespeedBeaconUrl that 
allows you to set a custom url for the beacon. You could potentially set this 
to 'ModPagespeedBeaconUrl /mod_pagespeed_beacon?customparam=value'. The beacon 
would then get sent to 
/mod_pagespeed_beacon?customparam=value&url=http%3A%2F%2Fwww.example.com. This 
doesn't 100% work yet, but if that meets your requirements it would be cleaner 
for us to fix and support compared to adding a new option.

Original comment by j...@google.com on 13 May 2013 at 8:54

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

That would work just fine for our case.

Original comment by hayes...@gmail.com on 15 May 2013 at 6:11

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This is fixed in 2 commits.

r3250 moves the url query param from the post body to the query param, and 
r3206 allows query params to be added to the custom beacon URL path with 
ModPagespeedBeaconUrl.

Original comment by j...@google.com on 25 Jun 2013 at 2:13

  • Added labels: Milestone-v29, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by j...@google.com on 25 Jun 2013 at 2:13

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by j...@google.com on 25 Jun 2013 at 6:06

  • Changed title: Add originating page URL query-param to beacon URL
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment