New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModPagespeedRewriteRandomDropPercentage cause duplicate image srcs to be blank. #748

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

Input HTML: <img src='a.png'> <img src='a.png'>
Output HTML: <img src='a.png'> <img src=''>

This can occur when RewriteRandomDropPercentage is set to something greater 
than zero and images have duplicate URLs in the same HTML document.  The later 
images have their URLs removed.

Original issue reported on code.google.com by jkar...@google.com on 24 Jul 2013 at 2:38

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

The problem was that RewriteContext::RepeatedSuccess did not pass the kTooBusy 
bit (was_too_busy_) from the primary context to the next in line, so the next 
in line rendered the empty URL.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Note that this means that it's also a bug for load shedding.

Original comment by jkar...@google.com on 24 Jul 2013 at 4:47

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jkar...@google.com on 24 Jul 2013 at 5:18

  • Added labels: Milestone-v29, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jkar...@google.com on 24 Jul 2013 at 5:46

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

1.6.29.5-beta was just released and we believe it will resolve the issue.  
Thanks for filing a bug report!

Josh

Original comment by jkar...@google.com on 25 Jul 2013 at 3:16

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Thankyou - I have implemented the latest beta version and the issue is indeed 
fixed.

Original comment by rwap.services on 26 Jul 2013 at 8:12

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jkar...@google.com on 26 Jul 2013 at 10:43

  • Changed state: Verified
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment