Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

mod_pagespeed disables mod_headers/mod_expires when proxying content with cache-control set #809

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 3 comments

Comments

@GoogleCodeExporter
Copy link

When used as an origin, Apache users typically set Cache-Control via 
mod_headers, which runs after mod_pagespeed in the Apache filter chain.  
However when mod_pagespeed is used in a proxy situation, where the upstream 
server has generated Cache-Control, this can trigger some broken logic that can 
cause mod_pagespeed to turn off mod_headers for HTML.

A workaround for this problem exists:
   ModPagespeedModifyCachingHeaders off

Original issue reported on code.google.com by jmara...@google.com on 24 Oct 2013 at 3:46

@GoogleCodeExporter
Copy link
Author

With help I found an easy way to repro:

  header add extra-header extra-value
  header add Cache-Control max-age=60 early

extra-header will be missing from HTML requests.  However if you add
   ModPagespeedModifyCachingHeaders off
it will show up fine.  I grant this is not intuitive.  Working on a fix.


Original comment by jmara...@google.com on 24 Oct 2013 at 4:36

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

A fix is in review.

There's a related issue, which I think is less severe -- which is that we might 
not include any mod_headers-related headers for .pagespeed. resource under a 
few conditions.  I'll track that separately in Issue 811.

Original comment by jmara...@google.com on 25 Oct 2013 at 2:39

@GoogleCodeExporter
Copy link
Author

Fixed in https://code.google.com/p/modpagespeed/source/detail?r=3560

Original comment by jmara...@google.com on 25 Oct 2013 at 8:50

  • Changed state: Fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant