New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod_pagespeed disables mod_headers/mod_expires when proxying content with cache-control set #809

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 3 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

When used as an origin, Apache users typically set Cache-Control via 
mod_headers, which runs after mod_pagespeed in the Apache filter chain.  
However when mod_pagespeed is used in a proxy situation, where the upstream 
server has generated Cache-Control, this can trigger some broken logic that can 
cause mod_pagespeed to turn off mod_headers for HTML.

A workaround for this problem exists:
   ModPagespeedModifyCachingHeaders off

Original issue reported on code.google.com by jmara...@google.com on 24 Oct 2013 at 3:46

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

With help I found an easy way to repro:

  header add extra-header extra-value
  header add Cache-Control max-age=60 early

extra-header will be missing from HTML requests.  However if you add
   ModPagespeedModifyCachingHeaders off
it will show up fine.  I grant this is not intuitive.  Working on a fix.


Original comment by jmara...@google.com on 24 Oct 2013 at 4:36

  • Changed state: Started
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

A fix is in review.

There's a related issue, which I think is less severe -- which is that we might 
not include any mod_headers-related headers for .pagespeed. resource under a 
few conditions.  I'll track that separately in Issue 811.

Original comment by jmara...@google.com on 25 Oct 2013 at 2:39

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Fixed in https://code.google.com/p/modpagespeed/source/detail?r=3560

Original comment by jmara...@google.com on 25 Oct 2013 at 8:50

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment