Skip to content
This repository was archived by the owner on Apr 10, 2025. It is now read-only.
This repository was archived by the owner on Apr 10, 2025. It is now read-only.

SerfThreadFn might compile with the wrong calling convention and crash on shutdown #812

@GoogleCodeExporter

Description

@GoogleCodeExporter
As the serf url fetcher uses apr threads to create and join threads the thread 
function should have the correct signature:

http://code.google.com/p/modpagespeed/source/browse/branches/latest-stable/src/n
et/instaweb/apache/serf_url_async_fetcher.cc#789

static void* SerfThreadFn(apr_thread_t* thread_id, void* context)

Should be:
static APR_DECLARE(void*) SerfThreadFn(apr_thread_t* thread_id, void* context)

include apr.h for the APR_DECLARE

It would be better to use the ThreadSystem instance used in construction of the 
fetcher.

Original issue reported on code.google.com by kspoels...@we-amp.com on 30 Oct 2013 at 11:13

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions