Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Cache-Control: no-transform has no effect if combined with other values #863

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

According to the documentation it should be possible to deactivate 
mod_pagespeed by sending a Cache-Control: no-transform header. 

This works as expected but if you combine no-transform with other values, 
mod_pagespeed ignores it. eg.: 

Cache-Control: no-cache, private, no-store, must-revalidate, max-stale=0, 
post-check=0, pre-check=0, max-age=0, no-transform

or

Cache-Control: no-cache, private, no-store, must-revalidate, no-transform, 
max-stale=0, post-check=0, pre-check=0, max-age=0

it only works if you add multiple Cache-Control headers to the response. 

What steps will reproduce the problem?
1. Send the following header: Cache-Control: no-cache, private, no-store, 
must-revalidate, max-stale=0, post-check=0, pre-check=0, max-age=0, no-transform

What is the expected output? What do you see instead?
mod_pagespeed should be deactivated. 

What version of the product are you using (please check X-Mod-Pagespeed
header)?
1.6.29.7-3566

On what operating system?
Debian 7.2

Which version of Apache?
Apache/2.2.22

Which MPM?
ITK

URL of broken page:
None


Original issue reported on code.google.com by bernhard.rusch@gmail.com on 8 Jan 2014 at 2:05

@GoogleCodeExporter
Copy link
Author

I think I see the problem in the code, but I want to check: your observation is 
about HTML responses.

I think no-transform as part of a multi-value cache-control should work fine 
for image, css, and JS files.

Is that consistent with what you've seen?

Original comment by jmara...@google.com on 8 Jan 2014 at 2:13

  • Changed state: RequestClarification

@GoogleCodeExporter
Copy link
Author

Yes that's corrent, the response is HTML. 
Image, CSS and Javascript works fine. 

Original comment by bernhard.rusch@gmail.com on 8 Jan 2014 at 2:36

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 8 Jan 2014 at 2:37

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

Original comment by jmara...@google.com on 8 Jan 2014 at 9:19

  • Changed state: Fixed
  • Added labels: Milestone-v31, release-note

@GoogleCodeExporter
Copy link
Author

Fixed in https://code.google.com/p/modpagespeed/source/detail?r=3709

Original comment by jmara...@google.com on 8 Jan 2014 at 9:22

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant