New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply IPRO on first request if InPlaceRewriteDeadlineMs is -1 and LoadFromFile is enabled. #871

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 7 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

IPRO does not apply on first request. Only second & sometimes third request 
kicks in IPRO.

More info from 
https://groups.google.com/forum/#!topic/mod-pagespeed-discuss/eFumbtrtGMA
I'm using MPS on static file servers only to strip meta data off image files. 
These static file servers are origin servers for CDNs.

Original issue reported on code.google.com by jihoon on 23 Jan 2014 at 1:35

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This would require the server to block while fetching the resource, then 
rewrite it.

We do NOT do this (*) because it adds too much latency to the initial request.

(*) Actually, there is a short timeout (10ms IIRC) -
    if it's done in that time then good, otherwise we serve the original content.

Also, there might be a way to force blocking of rewrites to give you what you 
want.
I'll check but someone else might chime in first with the answer.

Original comment by matterb...@google.com on 23 Jan 2014 at 3:45

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

There was a comment in the email thread linked about perhaps only allowing this 
feature if ModPagespeedLoadFromFile were also enabled. It seems reasonable 
(from a latency perspective) to allow blocking on the fetch if it were being 
loaded from disk instead of the http fetcher, but that might be a pretty 
substantial change to our architecture.

Original comment by j...@google.com on 23 Jan 2014 at 3:50

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Adding info from the email thread: This is with

ModPagespeedInPlaceRewriteDeadlineMs    -1

already enabled.

As others mentioned, this is technically difficult because of how IPRO was 
engineered. Part of the reason that it was engineered this way was because we 
expected that blocking rewrites slow down page views.

Original comment by sligocki@google.com on 23 Jan 2014 at 8:26

  • Changed title: Apply IPRO on first request (if InPlaceRewriteDeadlineMs -1)
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

In the next release, this will work.  If you set
   ModPagespeedInPlaceWaitForOptimized on
   ModPagespeedLoadFromFile xxx
FYI the support for InPlaceWaitForOptimized exists already in the code, but was 
not settable from the config.

I'm going to investigate whether setting InPlaceRewriteDeadlineMs to -1 will 
work that way too, and indeed what the difference between those two settings 
really is.

Original comment by jmara...@google.com on 29 Jan 2014 at 5:52

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

This issue was closed by revision r3747.

Original comment by jmara...@google.com on 30 Jan 2014 at 2:04

  • Changed state: Fixed
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 30 Jan 2014 at 2:09

  • Changed title: Apply IPRO on first request if InPlaceRewriteDeadlineMs -1 and LoadFromFile is enabled.
  • Added labels: Milestone-v31, release-note
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmaes...@google.com on 30 Apr 2014 at 9:25

  • Changed title: Apply IPRO on first request if InPlaceRewriteDeadlineMs is -1 and LoadFromFile is enabled.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment