New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing JS files can make combining/minification produce reference errors #881

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 4 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

1. make an HTML file referencing scripts a.js and b.js
2. enable rewrite_javascript and combine_javascript (both in core now)
3. rewrite the HTML file producing combined minified URL e.g.
   a.js,Mjm.HASH.js+b.js,Mjm.HASH.js.pagespeed.jc.HASH.js
4. somehow the metadata cache for the combination stays present but
   the http cache and the metadata cache for the minifications
   is flushed
5. change an identifier in a.js
6. refetch the combined minified file

I believe this will result in ReferenceErrors e.g. mod_pagespeed_63jkvFJpbY1 is 
not defined.

This has not been repro'd yet but should be easy to unit test.

Original issue reported on code.google.com by jmara...@google.com on 31 Jan 2014 at 2:07

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 31 Jan 2014 at 2:08

  • Now blocking: #558
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by jmara...@google.com on 31 Jan 2014 at 2:08

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Got a preliminary testcase, as a one line change from test for 880; will 
probably make a different now since that one needs a lot more tricky stuff.

Original comment by morlov...@google.com on 31 Jan 2014 at 3:08

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Should be fixed with r3802.

Original comment by morlov...@google.com on 20 Feb 2014 at 3:48

  • Changed state: Fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment