Skip to content
This repository has been archived by the owner on Apr 21, 2023. It is now read-only.

Run combine_javascript before rewrie_javascript, and have it do the minification inline #882

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments


Copy link

As discussed, this will result in less scheduling/nested-driver overhead, and 
shorter and less ugly URLs.

This may require use of PartitionAsync since the minification will need to be 
inline, and may be inappropriately compute-intensive for the rewrite thread.

This is a lower priority than the functional bugs of course.

Original issue reported on by on 31 Jan 2014 at 3:13

Copy link

OK I see this as important for making rollouts more deployable.

One thing I'd suggest is to only call the minifier from the combiner if 
RewriteOptions::kRewriteJavascript is enabled.

Original comment by on 4 Feb 2014 at 3:26

  • Added labels: Priority-High
  • Removed labels: Priority-Low

Copy link

Original comment by on 20 Mar 2014 at 8:36

  • Changed state: Fixed
  • Added labels: Milestone-v31

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

No branches or pull requests

1 participant