New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run combine_javascript before rewrie_javascript, and have it do the minification inline #882

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 2 comments

Comments

Projects
None yet
1 participant
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

As discussed, this will result in less scheduling/nested-driver overhead, and 
shorter and less ugly URLs.

This may require use of PartitionAsync since the minification will need to be 
inline, and may be inappropriately compute-intensive for the rewrite thread.

This is a lower priority than the functional bugs of course.

Original issue reported on code.google.com by jmara...@google.com on 31 Jan 2014 at 3:13

@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

OK I see this as important for making rollouts more deployable.

One thing I'd suggest is to only call the minifier from the combiner if 
RewriteOptions::kRewriteJavascript is enabled.

Original comment by jmara...@google.com on 4 Feb 2014 at 3:26

  • Added labels: Priority-High
  • Removed labels: Priority-Low
@GoogleCodeExporter

This comment has been minimized.

Copy link

GoogleCodeExporter commented Apr 6, 2015

Original comment by morlov...@google.com on 20 Mar 2014 at 8:36

  • Changed state: Fixed
  • Added labels: Milestone-v31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment