Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user defined attributes to override spec-defined ones. #928

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments
Closed

Allow user defined attributes to override spec-defined ones. #928

GoogleCodeExporter opened this issue Apr 6, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

It's currently possible to use UrlValuedAttribute to tell pagespeed to process 
additional tag attributes, but not to override existing ones.  Can we remove 
this limitation?

It looks like it's just a matter of switching the order of the "Handle 
spec-defined attributes" and "Handle user-defined attributes" code in 
resource_tag_scanner.cc

Original issue reported on code.google.com by jefftk@google.com on 14 Apr 2014 at 12:57

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fixed in r3937.

Original comment by jefftk@google.com on 14 Apr 2014 at 7:58

  • Changed state: Fixed
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Original comment by jmaes...@google.com on 18 Apr 2014 at 7:29

  • Added labels: Milestone-v31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant