New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not serve source map on Hash mismatch #931

Closed
GoogleCodeExporter opened this Issue Apr 6, 2015 · 1 comment

Comments

Projects
None yet
2 participants
@GoogleCodeExporter
Copy link

GoogleCodeExporter commented Apr 6, 2015

Source maps are served by the same process as rewritten resources. By default, 
if we get a request for a rewritten resource with a hash different from the one 
we have in cache, we'll still serve the one in cache (with 
Cache-Control:private,max-age=300).

This is very bad for source maps, because ones with different hashes are 
completely wrong. We should not serve these.

Original issue reported on code.google.com by sligocki@google.com on 21 Apr 2014 at 7:21

@sligocki sligocki self-assigned this Apr 9, 2015

sligocki added a commit that referenced this issue Jun 12, 2015

Fail to serve source maps if they have a hash mismatch. If the hash i…
…s different then the source map is completely useless and will only confuse users trying to debug.

Fixes Issue #931.
@sligocki

This comment has been minimized.

Copy link
Contributor

sligocki commented Jun 12, 2015

Fixed by fb49739

@sligocki sligocki closed this Jun 12, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment